Skip to content

Fix alignment and padding for RTL-language #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
7h30n3 merged 3 commits into from
Nov 6, 2025
Merged

Fix alignment and padding for RTL-language #329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
58f4004
Fix alignment and padding for RTL-language
7h30n3 Oct 30, 2025
02b45be
Fix further alignments
7h30n3 Nov 5, 2025
2ec8b30
Fix alignment on onboarding screen and question summary
7h30n3 Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions lib/screens/onboarding.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ class OnboardingScreen extends View<OnboardingViewModel> {
foregroundColor: Colors.white,
minimumSize: const Size(150, 36),
elevation: 0.0,
padding: const EdgeInsets.only(left: 14.0, right: 8.0),
padding: const EdgeInsetsDirectional.only(start: 14.0, end: 8.0),
shape: RoundedRectangleBorder(
borderRadius: BorderRadius.circular(12.0),
),
Expand Down Expand Up @@ -206,14 +206,12 @@ class OnboardingPage extends StatelessWidget {
image,
fit: BoxFit.fitWidth,
excludeFromSemantics: true,
matchTextDirection: true,
),
Flexible(
flex: 12,
child: Padding(
padding: const EdgeInsets.only(
left: 40.0,
right: 40.0,
),
padding: const EdgeInsets.symmetric(horizontal: 40),
child: Column(
mainAxisAlignment: MainAxisAlignment.center,
children: [
Expand Down
6 changes: 2 additions & 4 deletions lib/widgets/map_overlay/map_overlay.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,8 @@ class MapOverlay extends ViewFragment<HomeViewModel> {
container: true,
sortKey: const OrdinalSortKey(2.0),
child: AttributionText(
alignment: TextAlign.left,
padding: const EdgeInsets.symmetric(
horizontal: 10,
),
alignment: TextAlign.start,
padding: const EdgeInsets.symmetric(horizontal: 10),
children: [
AttributionTextPart(
AppLocalizations.of(context)!.osmAttributionText,
Expand Down
2 changes: 1 addition & 1 deletion lib/widgets/question_dialog/question_summary.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ class QuestionSummary extends StatelessWidget {
Expanded(
child: Text(
answer,
textAlign: TextAlign.right,
textAlign: TextAlign.end,
maxLines: 2,
overflow: TextOverflow.ellipsis,
),
Expand Down
2 changes: 1 addition & 1 deletion lib/widgets/question_dialog/question_text_header.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ class _QuestionTextHeaderState extends State<QuestionTextHeader>
animation: _fillColorAnimation,
builder: (context, child) {
return Container(
margin: const EdgeInsets.only(left: 10),
margin: const EdgeInsetsDirectional.only(start: 10),
padding: const EdgeInsets.all(4),
decoration: BoxDecoration(
color: _fillColorAnimation.value,
Expand Down
18 changes: 7 additions & 11 deletions lib/widgets/question_inputs/list_input.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,10 +118,10 @@ class _ListInputItemState extends State<ListInputItem> with SingleTickerProvider
crossAxisAlignment: CrossAxisAlignment.stretch,
children: [
Padding(
padding: const EdgeInsets.only(
left: 16.0,
padding: const EdgeInsetsDirectional.only(
start: 16.0,
top: 8.0,
right: 8.0,
end: 8.0,
bottom: 8.0,
),
child: Semantics(
Expand All @@ -132,7 +132,6 @@ class _ListInputItemState extends State<ListInputItem> with SingleTickerProvider
child: Text(
semanticsLabel: '${widget.label} - ${widget.description ?? ''}',
widget.label,
textAlign: TextAlign.left,
),
),
),
Expand All @@ -144,9 +143,9 @@ class _ListInputItemState extends State<ListInputItem> with SingleTickerProvider
child: FadeTransition(
opacity: _animation,
child: Padding(
padding: const EdgeInsets.only(
left: 16.0,
right: 8.0,
padding: const EdgeInsetsDirectional.only(
start: 16.0,
end: 8.0,
bottom: 8.0,
),
child: Text(
Expand All @@ -169,10 +168,7 @@ class _ListInputItemState extends State<ListInputItem> with SingleTickerProvider
// HeroViewer cannot be wrapped around since the returned error widget
// represents a different widget wherefore the hero transition would fail.
child: Padding(
padding: EdgeInsets.fromLTRB(
0,
widget.imagePadding,
widget.imagePadding,
padding: EdgeInsets.all(
widget.imagePadding,
),
child: ClipRRect(
Expand Down