fix: PermissionError on Email Queue for non-admin users#6033
Open
one-fm wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed
PermissionErroronEmail Queuefor non-admin users by bypassing UI-level permission checks during background email sending.Changes
one_fm/events/email_queue.py:send_mail(name)function to fetchEmail Queuedoc and calldoc.send()directly. This avoids thecheck_permissioncall inside the whitelistedsend_nowfunction.after_inserthook to enqueuesend_mailinstead ofsend_now.flush_emailsto usefrappe.get_all(bypassing list permissions) andsend_mail.Review Checklist
one_fm.patches.v15_0.fix_leave_allocation_carry_forward_hr_emp_02814. This patch fails because it expects a specific recordHR-LAL-2024-01853which is missing in the environment.)one_fm.events.email_queue.after_insertflush_emailsis a utility/background function.How to Verify
PermissionErrorin background jobs.Closes #6020