Fix: Correct employee resignation withdrawal workflow state …n from rejected to rejected and update process task assignment conditions to include accepted and rejected by supervisor states.#5784
Open
Talleyrand333 wants to merge 1 commit into
Conversation
…n from rejected to rejected and update process task assignment conditions to include accepted and rejected by supervisor states.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes two issues in the employee resignation withdrawal workflow: a bug where the "Reject" action from the "Rejected By Supervisor" state incorrectly transitioned to "Approved" instead of "Rejected", and an update to the assignment rule conditions to trigger on both supervisor-level states rather than the removed "Pending Operations Manager" state.
Changes:
- Fixed the workflow transition so that rejecting from "Rejected By Supervisor" now correctly leads to "Rejected" instead of "Approved"
- Updated the process task assignment rule conditions to assign on "Accepted by Supervisor" and "Rejected By Supervisor" states
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| one_fm/custom/workflow/employee_resignation_withdrawal.json | Corrects the next_state for the Reject action from "Rejected By Supervisor" state from "Approved" to "Rejected" |
| one_fm/patches/v15_0/add_process_task_employee_resignation_withdrawal_apprroval.py | Updates assign/unassign conditions to use "Accepted by Supervisor" and "Rejected By Supervisor" states instead of "Pending Operations Manager" |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is this a Feature, Chore or Bug?
Clearly and concisely describe the feature, chore or bug.
Analysis and design (optional)
Analyse and attach the design documentation
Solution description
Describe your code changes in detail for reviewers.
Is there a business logic within a doctype?
Output screenshots (optional)
Post the output screenshots, if a UI is affected or added due to this feature.
Areas affected and ensured
List out the areas affected by your code changes.
Is there any existing behavior change of other features due to this code change?
Mention Yes or No. If Yes, provide the appropriate explanation.
Did you test with the following dataset?
Was child table created?
Did you delete custom field?
Is patch required?
Was the patch test?
Which browser(s) did you use for testing?