Skip to content

Fix: Correct employee resignation withdrawal workflow state …n from rejected to rejected and update process task assignment conditions to include accepted and rejected by supervisor states.#5784

Open
Talleyrand333 wants to merge 1 commit into
stagingfrom
OFP-1450

Conversation

@Talleyrand333
Copy link
Copy Markdown
Contributor

Is this a Feature, Chore or Bug?

  • [] Feature
  • [] Chore
  • [] Bug

Clearly and concisely describe the feature, chore or bug.

Analysis and design (optional)

Analyse and attach the design documentation

Solution description

Describe your code changes in detail for reviewers.

Is there a business logic within a doctype?

- [] Yes
- [] No

Output screenshots (optional)

Post the output screenshots, if a UI is affected or added due to this feature.

Areas affected and ensured

List out the areas affected by your code changes.

Is there any existing behavior change of other features due to this code change?

Mention Yes or No. If Yes, provide the appropriate explanation.

Did you test with the following dataset?

  • [] Existing Data
  • [] New Data

Was child table created?

- [] is attachment required?
    did you test attachment

Did you delete custom field?

- [] Yes
- [] No
    If yes, did you write a delete patch?

Is patch required?

  • [] Yes
  • [] No

    Was the patch test?

Which browser(s) did you use for testing?

  • [] Chrome
  • [] Safari
  • [] Firefox

…n from rejected to rejected and update process task assignment conditions to include accepted and rejected by supervisor states.
Copilot AI review requested due to automatic review settings March 17, 2026 08:44
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes two issues in the employee resignation withdrawal workflow: a bug where the "Reject" action from the "Rejected By Supervisor" state incorrectly transitioned to "Approved" instead of "Rejected", and an update to the assignment rule conditions to trigger on both supervisor-level states rather than the removed "Pending Operations Manager" state.

Changes:

  • Fixed the workflow transition so that rejecting from "Rejected By Supervisor" now correctly leads to "Rejected" instead of "Approved"
  • Updated the process task assignment rule conditions to assign on "Accepted by Supervisor" and "Rejected By Supervisor" states

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
one_fm/custom/workflow/employee_resignation_withdrawal.json Corrects the next_state for the Reject action from "Rejected By Supervisor" state from "Approved" to "Rejected"
one_fm/patches/v15_0/add_process_task_employee_resignation_withdrawal_apprroval.py Updates assign/unassign conditions to use "Accepted by Supervisor" and "Rejected By Supervisor" states instead of "Pending Operations Manager"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants