Repository navigation
Doc2FAQ v0.5: source viewer, review status, and combined filters - #13
Merged
Merged
Conversation
OKAN-SOFTWARE
marked this pull request as ready for review
November 6, 2026 18:35
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1e7037c484
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Select an FAQ to highlight all of its exact original passages beside the answer editor on desktop, with a stacked source viewer on mobile. Complete FAQs can be marked Approved or Needs review; editing either field or merging resets approval.
Combine question/answer search with status filters and visible/approval counts. Filters affect only the review list: saves, export previews, and every export format retain all FAQs in draft order. Hidden incomplete entries still block export.
Review status survives project downloads and optional autosave. Schema-1 projects upgrade with Needs review defaults; new schema-2 saves require v0.5 or later. Development builds use 0.5.0-SNAPSHOT; v0.4.0 remains the published download.
Review fix
Typing in the question or answer now preserves the source viewer DOM and scroll position. Only explicitly opening or changing the source selection scrolls to a highlighted passage. A regression test reproduced the original issue; the fix passed a real mobile browser check with multiple source passages and the full desktop/mobile smoke checks.
Validation
CI: https://github.com/OKAN-SOFTWARE/Doc2FAQ/actions/runs/42272623286
The release checklist covers the new workflow. Packaged-JAR manual smoke testing and release publication remain separate; no release has been published.