Add copy to clipboard option for capture #5720
Conversation
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Viewers
|
||||||||||||||||||||||||||||
| Project |
Viewers
|
| Branch Review |
fix/save-jpeg
|
| Run status |
|
| Run duration | 02m 15s |
| Commit |
|
| Committer | Bill Wallace |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
37
|
| View all changes introduced in this branch ↗︎ | |
| } | ||
| }} | ||
| > | ||
| {t('Copy to Clipboard')} |
There was a problem hiding this comment.
Please add this to the json i18n files so that when someone goes to do a translation like what was recently done for French, it makes their job a little easier. Thanks.
jbocce
left a comment
jbocce
left a comment
There was a problem hiding this comment.
Changes look fine. One minor comment. I also added @aimee-ferreira as a reviewer so she can test these changes on merge instead of having to wait for the release. Let's not merge until she has finished having a look. Thanks.
|
Also @wayfarer3130 we should create a linear issue so that there is tracking of this. |
aimee-ferreira
left a comment
aimee-ferreira
left a comment
There was a problem hiding this comment.
Hi @wayfarer3130,
Selecting the capture tool in MPR layout and choosing any of the options (cancel, copy to clipboard, save) shifts the images right. It happens for any of the 3 MPR images. It doesn't happen on ohif-dev so think this might have been introduced with this change. Can you please take a look? Thanks.
Context
Add a copy to clipboard and fix a couple of rendering issues with how the capture viewport is setup/managed.
Changes & Results
Click on capture on an MPR oblique viewport, the capture image should look like the source image.
Click on copy to clipboard, it should store the image to be pasteable to another application.
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment