Add Conventions for Creating OMOP Extension Tables#207
Open
jshoughtaling wants to merge 2 commits intoOHDSI:masterfrom
Open
Add Conventions for Creating OMOP Extension Tables#207jshoughtaling wants to merge 2 commits intoOHDSI:masterfrom
jshoughtaling wants to merge 2 commits intoOHDSI:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@MelaniePhilofsky - this PR creates a document that describes, in detail, the requirements for formalizing extension tables to the OMOP CDM. Your feedback during the WaveformWG presentation at the steering committee meeting was the impetus for this doc, and it has broad implications for at least five OHDSI working groups. I didn't follow the standard THEMIS workflow of -> Issue, Themis Meeting/Discussion, PR - simply because this is a convention not necessarily related to ambiguity in the OMOP data model itself, but rather in extending that model. I'd be happy to present the contents of this doc at an upcoming THEMIS call if you'd like, though it was my understanding that folks generally agreed that we should follow the approach taken by the Imaging WG when creating extensions, and I've tried to capture their approach here.