[devops] Update GHA ci for release workflow#2860
Open
mwaiyee wants to merge 4 commits into
Open
Conversation
… mwaiyee/ci-release-workflow
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the docker-build-push GitHub Actions workflow to better support manual, workflow-dispatch-driven releases by allowing operators to provide a release tag and select which NPM artifact feed to target.
Changes:
- Adds
workflow_dispatchinputs (release_tag,artifacttype) and threads a newplugins_tagoutput through the workflow. - Updates plugin package versioning logic to set an explicit release version during workflow-dispatch runs.
- Adds conditional Node/registry setup to publish to either the “develop” or “stable” Azure Artifacts NPM registry.
Comment on lines
87
to
+89
| IS_RELEASE_PUSH=true | ||
| CANONICAL_TAG="${REL_SLUG}" | ||
| CANONICAL_TAG="" | ||
| PLUGINS_TAG="" |
Collaborator
Author
There was a problem hiding this comment.
changed to REL_SLUG for CANONICAL_TAG (eg release-v0.16.0-beta)
Comment on lines
+363
to
+368
| if [[ $GITHUB_EVENT_NAME == 'workflow_dispatch' ]]; then | ||
| RELEASE_VERSION=${{ needs.setup.outputs.plugins_tag }} | ||
| jq --arg v $RELEASE_VERSION '.version=$v' package.json > tmppkg; mv tmppkg package.json | ||
| else | ||
| jq --arg v "-$(date +%s)-$GITHUB_SHA" '.version+=$v' package.json > tmppkg; mv tmppkg package.json | ||
| fi |
Comment on lines
+415
to
+418
| with: | ||
| node-version: "18.x" | ||
| registry-url: "https://pkgs.dev.azure.com/data2evidence/d2e/_packaging/stable/npm/registry/" | ||
| scope: "@data2evidence" |
… mwaiyee/ci-release-workflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
Please cross check this list if additions / modifications needs to be done on top of your core changes and tick them off. Reviewer can as well glance through and help the developer if something is missed out.
developbranch)