[Data-11] Cache Attach fix#2835
Open
Zhimin-arya wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Trex server startup cache attachment so cache databases can be attached even when the underlying .db file doesn’t exist yet (allowing DuckDB to create it on first attach), addressing cache attach failures at startup.
Changes:
- Remove the previous startup logic that enumerated HANA datasets and attempted to attach their caches explicitly.
- Pass
createDbFileIfMissing: truewhen attaching portal-derivedcache_iddatabases during startup.
brandantck
approved these changes
Jul 2, 2026
csafreen
reviewed
Jul 3, 2026
| try { | ||
| await ensureCacheAttached(ds.code, { | ||
| cacheDir: "/usr/src/data/cache", | ||
| await ensureCacheAttached(`${ds.code}_cache`, { |
Collaborator
There was a problem hiding this comment.
why is _cache added for HANA datasets?
Collaborator
Author
There was a problem hiding this comment.
Because if cache_id == database_code trex routes to directly HANA connection, but in search_embedding we need hana cache in duckdb cache. So append _cache makes trex to connect cache instead.
csafreen
requested changes
Jul 3, 2026
csafreen
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
createDbFileIfMissing=truewhen attach HANA to duckdb cache, set the cache name as${database_code}_cache.dbScreen.Recording.2026-07-02.at.15.15.29.mov
developbranch)