[Integrate-2599] upgrade Logto to 1.40.1 with D2E adaptations#2827
Open
suwarnoong wants to merge 1 commit into
Open
[Integrate-2599] upgrade Logto to 1.40.1 with D2E adaptations#2827suwarnoong wants to merge 1 commit into
suwarnoong wants to merge 1 commit into
Conversation
suwarnoong
requested review from
SantanM,
brandantck,
csafreen,
hengxian-jiang and
p-hoffmann
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Upgrades the embedded Logto integration to align with Logto 1.40.1 while preserving Data2Evidence-specific adaptations (sign-in flow tweaks, custom JWT behavior, and deployment/config updates).
Changes:
- Updates sign-in page behavior (redirect handling + password-only detection refactor).
- Extends custom JWT customization support (application context, regional Azure Functions execution path, token passthrough extras).
- Bumps connector dependencies and updates local/dev compose DB alteration deploy target to 1.40.1.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| services/alp-logto/to-replace/SignIn/Main.tsx | Refactors sign-in routing/redirect and password-only flow selection logic. |
| services/alp-logto/to-replace/core/src/libraries/jwt-customizer.ts | Adds regional Azure Functions execution path and additional JWT customizer context handling. |
| services/alp-logto/post-init/src/main.ts | Updates injected Logto UI CSS customization used during post-init provisioning. |
| services/alp-logto/connector-alp-entra-external-id/package.json | Updates connector-kit and zod versions for Entra External ID connector. |
| services/alp-logto/connector-alp-azuread/package.json | Updates connector-kit and zod versions for Azure AD connector. |
| docker-compose.yml | Updates Logto DB alteration deploy version used by compose startup to 1.40.1. |
| import useTerms from '@/hooks/use-terms'; | ||
| import LoadingLayer from '@/shared/components/LoadingLayer'; | ||
|
|
||
| import useIdentifierSignInMethods from '../IdentifierSignIn/use-identifier-sign-in-methods'; |
| signInMethods.length > 0 && | ||
| signInMethods.every(({ password, verificationCode }) => password && !verificationCode); | ||
|
|
||
| if (isPasswordOnly) { |
Comment on lines
+45
to
46
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| }, [isRedirecting, isLogout]); |
Comment on lines
106
to
109
| if (globalThis.tokenMap) { | ||
| // @ts-ignore | ||
| delete globalThis.tokenMap[mapId]; | ||
| // eslint-disable-next-line @silverhand/fp/no-mutation | ||
| globalThis.tokenMap[mapId] = undefined; | ||
| } |
Comment on lines
+337
to
+344
| const result = await got | ||
| .post(new URL('/api/custom-jwt', azureFunctionUntrustedAppEndpoint), { | ||
| json: payload, | ||
| headers: { | ||
| 'x-functions-key': azureFunctionUntrustedAppKey, | ||
| }, | ||
| }) | ||
| .json<unknown>(); |
| customCss: | ||
| process.env.LOGTO__CUSTOM_CSS || | ||
| `a[aria-label="Powered By Logto"] { display: none; } | ||
| `[data-logto-signature="secured"][data-logto-signature="secured"] { display: none !important; } |
suwarnoong
force-pushed
the
suwarnoong/2599
branch
from
e19d507 to
f21913a
Compare
suwarnoong
force-pushed
the
suwarnoong/2599
branch
from
f21913a to
b5edd25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
Please cross check this list if additions / modifications needs to be done on top of your core changes and tick them off. Reviewer can as well glance through and help the developer if something is missed out.
developbranch)