Skip to content

Fix template strings#95

Merged
Sylensky merged 1 commit into
OG-star-tech:mainfrom
seva-luchianov:issue-94
Mar 7, 2026
Merged

Fix template strings#95
Sylensky merged 1 commit into
OG-star-tech:mainfrom
seva-luchianov:issue-94

Conversation

@seva-luchianov
Copy link
Copy Markdown
Contributor

Fixes #94
%STR_LOCAL_TIME% no longer reset everytime updateLocalTime() is called
%STR_TITLE% is now properly set using document.title attribute

%STR_LOCAL_TIME% no longer reset everytime updateLocalTime() is called
%STR_TITLE% is now properly set using document.title attribute
@seva-luchianov
Copy link
Copy Markdown
Contributor Author

Looks like the GHA formatting check is failing with

Unable to find image 'ghcr.io/jidicula/clang-format:13' locally
13: Pulling from jidicula/clang-format
docker: failed to copy: httpReadSeeker: failed open: content at https://ghcr.io/v2/jidicula/clang-format/manifests/sha256:fde2b85a55b977f83558b65b328d9f04be8be763e4c7bb5c40ae8a8e1724e09c not found: not found

Comment thread esp32_wireless_control/firmware/interface/index.html
@Sylensky
Copy link
Copy Markdown
Member

Thanks for the hint ill check the issue with clang-format later.

@Sylensky
Copy link
Copy Markdown
Member

Looks like the GHA formatting check is failing with

Unable to find image 'ghcr.io/jidicula/clang-format:13' locally
13: Pulling from jidicula/clang-format
docker: failed to copy: httpReadSeeker: failed open: content at https://ghcr.io/v2/jidicula/clang-format/manifests/sha256:fde2b85a55b977f83558b65b328d9f04be8be763e4c7bb5c40ae8a8e1724e09c not found: not found

Seems like the github action repository is onto this, see jidicula/clang-format-action#267.

@Sylensky Sylensky self-assigned this Feb 16, 2026
@Sylensky
Copy link
Copy Markdown
Member

This looks good to me, code vise but lets wait with merging until the action is working again.

@seva-luchianov
Copy link
Copy Markdown
Contributor Author

@Sylensky poke
Looks like the action was fixed, are we able to get this merged?

@Sylensky
Copy link
Copy Markdown
Member

Sylensky commented Mar 7, 2026

@Sylensky poke Looks like the action was fixed, are we able to get this merged?

Yes we can merge it.

@Sylensky Sylensky merged commit a865a9a into OG-star-tech:main Mar 7, 2026
1 of 2 checks passed
@Sylensky Sylensky added the bug Something isn't working label Mar 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Minor UI issues spotted in firmware v2.1

2 participants