feat!: migrate HOCR conversion to internal implementation - #3
Merged
Conversation
BREAKING CHANGE: Remove dependency on ocrbridge.core.utils.easyocr_to_hocr and implement HOCR conversion internally. This requires ocrbridge-core>=3.0.0 which no longer provides the easyocr_to_hocr utility function. - Add internal hocr.py module with to_hocr() conversion function - Implement _group_words_into_lines() for line detection - Update engine.py to use internal hocr_utils instead of core utilities - Bump ocrbridge-core dependency to >=3.0.0 This change makes the EasyOCR engine self-contained for HOCR conversion, reducing coupling with ocrbridge-core and allowing independent evolution of the conversion logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Remove dependency on ocrbridge.core.utils.easyocr_to_hocr and implement HOCR conversion internally. This requires ocrbridge-core>=3.0.0 which no longer provides the easyocr_to_hocr utility function.
This change makes the EasyOCR engine self-contained for HOCR conversion, reducing coupling with ocrbridge-core and allowing independent evolution of the conversion logic.