fix: address critical code review issues - #28
Merged
Conversation
Security & Resource Management: - Replace NamedTemporaryFile with TemporaryDirectory for secure temp files - Add GPU memory cleanup when changing languages (del reader + cuda.empty_cache) - Add thread safety documentation warning Code Quality: - Use xml.sax.saxutils.escape for robust XML escaping - Add guard for zero median height in line grouping to prevent division by zero 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security & Resource Management
NamedTemporaryFile(delete=False)withTemporaryDirectoryfor secure temp files (fixes race condition and permission issues)del reader+torch.cuda.empty_cache())Code Quality
xml.sax.saxutils.escapefor robust XML escaping instead of manual string replacementTest plan
make lint- no issuesmake test- tests pass (requires easyocr installation)🤖 Generated with Claude Code