[ByteMeAsap]

This fix avoids defining/overriding the elements(variables/methods) defined in static/lib/altcha.js as global elements so that other functionalities work as expected.

For instance, while I was working on adding the altcha for website_payment module , I had to inherit the _initiatePaymentFlow method. This method in the base make use of Bootstrap Popover as can be seen at https://github.com/odoo/odoo/blob/bcd8e82cf06ae78299144bc1f35b53fab36540b8/addons/website_payment/static/src/js/payment_form.js#L79 . But since the altcha.js also defines Popover at

website/website_altcha/static/lib/altcha.js

Line 5432 in 9945a34

function Popover($$anchor, $$props) {

, it leads to a TypeError: Popover.getOrCreateInstance is not a function.

[OCA-git-bot]

Hi @hbrunn,
some modules you are maintaining are being modified, check this out!

[tarteo]

Confirmed, this fixes the issue.

[ByteMeAsap]

@hbrunn , can you please check this?

[hbrunn]

nagging me not even a week after ocabot already notified me usually has adverse effects up to getting you on my block list.

that being said, thanks for this. though I'm not a fan of modifying bundled files, we can only load js assets as modules from v20 conveniently and implementing this here doesn't seem worth the hassle

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[hbrunn]

/ocabot merge patch

[OCA-git-bot]

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-1232-by-hbrunn-bump-patch, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 9e1ecc7. Thanks a lot for contributing to OCA. ❤️