Repository navigation
[FIX] website_altcha: remove parent too on edition - #1228
Merged
Merged
Conversation
hbrunn
reviewed
Oct 7, 2026
hbrunn
left a comment
Member
There was a problem hiding this comment.
I wonder if we aren't better off to just not insert the widget if this.editableMode is true?
Contributor
|
Hi @hbrunn, |
Member
Author
|
The problem is that the insertion happens once, before we press the editionMode button. I made a test to verify it again, but this is the main problem.
|
Member
Author
|
/ocabot merge patch Fast tracking as this might provoke errors |
Contributor
|
What a great day to merge this nice PR. Let's do it! |
Contributor
|
Congratulations, your PR was merged at 9945a34. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise, after edition, empty divs start to appear:
System was already prepared for this, however, at some point I probably deleted the class.
@hbrunn