Skip to content

[FIX] website_altcha: remove parent too on edition - #1228

Merged
OCA-git-bot merged 1 commit into
OCA:18.0from
dixmit:18.0-fix-altcha
Oct 7, 2026
Merged

OCA-git-bot merged 1 commit into
OCA:18.0from
dixmit:18.0-fix-altcha

Conversation

@etobella

@etobella etobella commented Oct 7, 2026

Copy link
Copy Markdown
Member

Otherwise, after edition, empty divs start to appear:

image

System was already prepared for this, however, at some point I probably deleted the class.

@hbrunn

@hbrunn hbrunn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we aren't better off to just not insert the widget if this.editableMode is true?

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hi @hbrunn,
some modules you are maintaining are being modified, check this out!

@etobella

etobella commented Oct 7, 2026

Copy link
Copy Markdown
Member Author

The problem is that the insertion happens once, before we press the editionMode button. I made a test to verify it again, but this is the main problem.

  1. We access the web
  2. Javascripts inserts the widget
  3. We press the edit button.
  4. Now, the page is not rerendered, it just passes the EditModeWebsiteForm start.

@hbrunn hbrunn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for checking

@etobella

etobella commented Oct 7, 2026

Copy link
Copy Markdown
Member Author

/ocabot merge patch

Fast tracking as this might provoke errors

@OCA-git-bot

Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-1228-by-etobella-bump-patch, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit 6375c9b into OCA:18.0 Oct 7, 2026
7 checks passed
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 9945a34. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants