Repository navigation
[18.0][IMP] website_altcha: allow appending the widget - #1221
Conversation
|
Hi @hbrunn, |
jans23
changed the title
88e6025 to
34b3231
Compare
|
This PR has the |
| this.$el | ||
| .find(this.altcha_prepend_to) | ||
| .prepend(renderToString("website_altcha.AltchaWidget", {})); | ||
| if (this.altcha_append_to) { |
There was a problem hiding this comment.
Can we also have before and after as options for altcha widget ? Something like the following allowing for more flexibility with the altcha placement.
if (this.altcha_before) { this.$el .find(this.altcha_before) .before(renderToString("website_altcha.AltchaWidget", {})); } else if (this.altcha_after) { this.$el .find(this.altcha_after) .after(renderToString("website_altcha.AltchaWidget", {})); } else if (this.altcha_append_to) {
There was a problem hiding this comment.
I'd add extra options here as need arises
There was a problem hiding this comment.
Doing div:has(<original css selector here>) you could do a before and after. I suggest we merge this PR, and do this later when necessary. @ByteMeAsap are you okay with that?
There was a problem hiding this comment.
Or @jans23 is it for you a small effort to add these extra options?
There was a problem hiding this comment.
Now I added "before" and "after".
Add altcha_append_to so that inheriting widgets can append the widget to an element instead of prepending it, such as website_mass_mailing_altcha. Assisted-by: Claude Opus 5.5 (1M context)
34b3231 to
d0c2420
Compare
|
@pilarvargas-tecnativa could you merge this please? |
|
/ocabot merge minor |
|
Sorry @pilarvargas-tecnativa you are not allowed to merge. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
|
/ocabot merge minor |
|
What a great day to merge this nice PR. Let's do it! |
|
That’s right! I got it wrong, I thought it was in e-commerce :S |
|
Congratulations, your PR was merged at fb33d1a. Thanks a lot for contributing to OCA. ❤️ |
7 participants
Add altcha_append_to so that inheriting widgets can append the widget to an element instead of prepending it, such as website_mass_mailing_altcha.
Assisted-by: Claude Opus 5.5 (1M context)