[16.0][ADD] website_recaptcha_v2_form by edescalona · Pull Request #1076 · OCA/website

edescalona · 2024-12-06T13:22:18Z

@BinhexTeam
Adding recaptcha version 2 for the form snippets and also in the login, password reset and register forms.

christian-ramos-tecnativa

Thanks for your contribution, check my comments please and remember to squash your commits into one.

jorgeglez1990

Greetings,
It has been functionally tested, and it works correctly except when, on /web/login, we log in without verifying the reCAPTCHA, which results in a 500: Internal Server Error.

edescalona · 2024-12-25T21:06:44Z

Greetings, It has been functionally tested, and it works correctly except when, on /web/login, we log in without verifying the reCAPTCHA, which results in a 500: Internal Server Error.

hello @jorgeglez1990 I'll check it out now, thanks for your cooperation.

edescalona · 2025-01-07T06:51:08Z

Hi @nobuQuartile , I solved the error you mentioned. When I can, please check and confirm. Thanks.

nobuQuartile · 2025-01-07T08:58:29Z

Hi @nobuQuartile , I solved the error you mentioned. When I can, please check and confirm. Thanks.

Hi @edescalona, I checked and confirmed the problem is solved at the ruboat. Thanks.

Honeyxilia

Hello - first of all, thank you for the work on this module to add a basic controller functionnality c:

I had a couple of questions before approving the changes

Honeyxilia · 2025-07-15T13:05:56Z

+    def valid_recaptcha(self, values):
+        valid, message = self.is_recaptcha_v2_valid(values)
+        if not valid:
+            raise AccessDenied(message)
+        return True


I think this wrapper method is not really necessary, as it doesn't accomplish much more than link an AccessDenied exception with the error message, which should already be considered a fail state.
=> What is the reasonning behind this wrapper, that can't be fulfilled using the return tuple of is_recaptcha_v2_valid ?

Hi @Honeyxilia , thanks for your comments. Basically, I want to show the message returned by the recaptcha verification as access denied, and then capture the exception in the controller.

github-actions · 2025-11-30T12:49:17Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

cubells · 2026-02-22T10:55:52Z

@nobuQuartile @yostashiro @Honeyxilia

Can you accept changes?

Thanks a lot!

jelenapoblet · 2026-10-09T13:35:17Z

@Yoshiro009 this has been on the loop for long time now, we're going to push and merge during today's internal sprint

jelenapoblet · 2026-10-09T13:42:09Z

@jorgeglez1990 can you review this please ?

Not following up

jorgeglez1990

LGTM

…orm snippets and also in the login, password reset and register forms.

edescalona · 2026-10-09T14:30:10Z

Hi @jelenapoblet , could you try merging this PR if you deem it appropriate?

jelenapoblet · 2026-10-09T14:58:26Z

/ocabot merge nobump

OCA-git-bot · 2026-10-09T14:58:40Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1076-by-jelenapoblet-bump-nobump, awaiting test results.

OCA-git-bot · 2026-10-09T15:03:44Z

@jelenapoblet The merge process could not be finalized, because command twine upload --disable-progress-bar --non-interactive --repository-url https://upload.pypi.org/legacy/ -u __token__ odoo_addon_website_recaptcha_v2_form-16.0.1.0.0.2-py3-none-any.whl failed with output:

Uploading distributions to https://upload.pypi.org/legacy/
Uploading odoo_addon_website_recaptcha_v2_form-16.0.1.0.0.2-py3-none-any.whl
�[33mWARNING �[0m Error during upload. Retry with the --verbose option for more details. 
�[31mERROR   �[0m HTTPError: 429 Too Many Requests from https://upload.pypi.org/legacy/  
         Too Many Requests

jelenapoblet · 2026-10-09T17:30:41Z

@OCA/pypi-support to reserve this name please. Thanks

rousseldenis · 2026-10-13T07:05:32Z

@jelenapoblet Could you retry merge ?

jelenapoblet · 2026-10-13T08:00:18Z

/ocabot merge nobump

OCA-git-bot · 2026-10-13T08:00:33Z

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1076-by-jelenapoblet-bump-nobump, awaiting test results.

OCA-git-bot · 2026-10-13T08:06:32Z

@jelenapoblet The merge process could not be finalized, because command twine upload --disable-progress-bar --non-interactive --repository-url https://upload.pypi.org/legacy/ -u __token__ odoo_addon_website_recaptcha_v2_form-16.0.1.0.0.2-py3-none-any.whl failed with output:

Uploading distributions to https://upload.pypi.org/legacy/
Uploading odoo_addon_website_recaptcha_v2_form-16.0.1.0.0.2-py3-none-any.whl
�[33mWARNING �[0m Error during upload. Retry with the --verbose option for more details. 
�[31mERROR   �[0m HTTPError: 429 Too Many Requests from https://upload.pypi.org/legacy/  
         Too Many Requests

Signed-off-by jelenapoblet

edescalona · 2026-10-20T14:26:40Z

@jelenapoblet could you please try again merge?

jelenapoblet · 2026-10-20T15:38:57Z

/ocabot merge nobump

OCA-git-bot · 2026-10-20T15:39:11Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1076-by-jelenapoblet-bump-nobump, awaiting test results.

OCA-git-bot · 2026-10-20T16:05:09Z

@jelenapoblet The merge process could not be finalized, because command twine upload --disable-progress-bar --non-interactive --repository-url https://upload.pypi.org/legacy/ -u __token__ odoo_addon_website_recaptcha_v2_form-16.0.1.0.0.2-py3-none-any.whl failed with output:

Uploading distributions to https://upload.pypi.org/legacy/
Uploading odoo_addon_website_recaptcha_v2_form-16.0.1.0.0.2-py3-none-any.whl
�[33mWARNING �[0m Error during upload. Retry with the --verbose option for more details. 
�[31mERROR   �[0m HTTPError: 429 Too Many Requests from https://upload.pypi.org/legacy/  
         Too Many Requests

Signed-off-by jelenapoblet

jelenapoblet · 2026-10-21T18:43:52Z

@OCA/pypi-support hi team, please reserve this one

edescalona mentioned this pull request Dec 6, 2024

[16.0][ADD] website_recaptcha_v2_login #1075

Closed

edescalona force-pushed the 16.0-add-website_recaptcha_v2_form branch from 74618c9 to 8b4f216 Compare December 6, 2024 16:27

christian-ramos-tecnativa previously requested changes Dec 10, 2024

View reviewed changes

Comment thread website_recaptcha_v2_form/controllers/main.py Outdated

Comment thread website_recaptcha_v2_form/models/website.py Outdated

Comment thread website_recaptcha_v2_form/readme/CONTRIBUTORS.md Outdated

Comment thread website_recaptcha_v2_form/readme/CONFIGURE.md

edescalona force-pushed the 16.0-add-website_recaptcha_v2_form branch from cf7f6d2 to e07469c Compare December 24, 2024 03:19

jorgeglez1990 suggested changes Dec 24, 2024

View reviewed changes

nobuQuartile reviewed Jan 7, 2025

View reviewed changes

Comment thread website_recaptcha_v2_form/models/res_config_settings.py Outdated

yostashiro reviewed Jan 7, 2025

View reviewed changes

Comment thread website_recaptcha_v2_form/models/res_config_settings.py Outdated

edescalona requested review from christian-ramos-tecnativa and jorgeglez1990 April 21, 2025 19:21

edescalona force-pushed the 16.0-add-website_recaptcha_v2_form branch from 075722c to bce9e9b Compare April 21, 2025 19:27

edescalona mentioned this pull request May 20, 2025

[17.0][MIG] website_recaptcha_v2_form #1103

Open

1 task

edescalona force-pushed the 16.0-add-website_recaptcha_v2_form branch from bce9e9b to 1c2ed62 Compare July 8, 2025 20:17

Honeyxilia reviewed Jul 15, 2025

View reviewed changes

edescalona force-pushed the 16.0-add-website_recaptcha_v2_form branch from 1c2ed62 to fe773e2 Compare July 28, 2025 23:19

github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 30, 2025

github-actions Bot closed this Jan 4, 2026

jelenapoblet reopened this Oct 9, 2026

OCA-git-bot added series:16.0 mod:website_recaptcha_v2_form Module website_recaptcha_v2_form labels Oct 9, 2026

jorgeglez1990 approved these changes Oct 9, 2026

View reviewed changes

edescalona force-pushed the 16.0-add-website_recaptcha_v2_form branch from fe773e2 to 0916317 Compare October 9, 2026 13:52

[ADD] website_recaptcha_v2_form: Adding recaptcha version 2 for the f…

86cdcb1

…orm snippets and also in the login, password reset and register forms.

edescalona force-pushed the 16.0-add-website_recaptcha_v2_form branch from 0916317 to 86cdcb1 Compare October 9, 2026 14:25

OCA-git-bot added the bot is merging ⏳ label Oct 9, 2026

OCA-git-bot removed the bot is merging ⏳ label Oct 9, 2026

jelenapoblet mentioned this pull request Oct 9, 2026

[17.0][MIG] website_recaptcha_v2 #1102

Open

github-actions Bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 11, 2026

OCA-git-bot added the bot is merging ⏳ label Oct 13, 2026

OCA-git-bot removed the bot is merging ⏳ label Oct 13, 2026

bt-admin pushed a commit to brain-tec/website that referenced this pull request Oct 14, 2026

Merge PR OCA#1076 into 16.0

c3ae660

Signed-off-by jelenapoblet

OCA-git-bot added the bot is merging ⏳ label Oct 20, 2026

OCA-git-bot removed the bot is merging ⏳ label Oct 20, 2026

bt-admin pushed a commit to brain-tec/website that referenced this pull request Oct 20, 2026

Merge PR OCA#1076 into 16.0

6b3c20c

Signed-off-by jelenapoblet

Conversation

edescalona commented Dec 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

christian-ramos-tecnativa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jorgeglez1990 left a comment

Choose a reason for hiding this comment

Uh oh!

edescalona commented Dec 25, 2024

Uh oh!

Uh oh!

edescalona commented Jan 7, 2025

Uh oh!

Uh oh!

nobuQuartile commented Jan 7, 2025

Uh oh!

Honeyxilia left a comment

Choose a reason for hiding this comment

Uh oh!

Honeyxilia Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

edescalona Jul 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Nov 30, 2025

Uh oh!

cubells commented Feb 22, 2026

Uh oh!

jelenapoblet commented Oct 9, 2026

Uh oh!

jelenapoblet commented Oct 9, 2026

Uh oh!

jorgeglez1990 left a comment

Choose a reason for hiding this comment

Uh oh!

edescalona commented Oct 9, 2026

Uh oh!

jelenapoblet commented Oct 9, 2026

Uh oh!

OCA-git-bot commented Oct 9, 2026

Uh oh!

OCA-git-bot commented Oct 9, 2026

Uh oh!

jelenapoblet commented Oct 9, 2026

Uh oh!

rousseldenis commented Oct 13, 2026

Uh oh!

jelenapoblet commented Oct 13, 2026

Uh oh!

OCA-git-bot commented Oct 13, 2026

Uh oh!

OCA-git-bot commented Oct 13, 2026

Uh oh!

edescalona commented Oct 20, 2026

Uh oh!

jelenapoblet commented Oct 20, 2026

Uh oh!

OCA-git-bot commented Oct 20, 2026

Uh oh!

OCA-git-bot commented Oct 20, 2026

Uh oh!

jelenapoblet commented Oct 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

edescalona commented Dec 6, 2024 •

edited

Loading