Skip to content

[MIG] purchase_tier_validation: Migration to 19.0#7

Open
jaydeep32 wants to merge 51 commits intoOCA:19.0from
archeti-org:19.0-mig-purchase_tier_validation
Open

[MIG] purchase_tier_validation: Migration to 19.0#7
jaydeep32 wants to merge 51 commits intoOCA:19.0from
archeti-org:19.0-mig-purchase_tier_validation

Conversation

@jaydeep32
Copy link
Copy Markdown

No description provided.

@bosd
Copy link
Copy Markdown

bosd commented Jan 30, 2026

Can you please fix the tests by adding the test requirements?

@jaydeep32
Copy link
Copy Markdown
Author

Yes, sure, but I have never done that before, so do you have any possible examples or guidelines on what and how to add?
And a possible file structure as well.

@bosd
Copy link
Copy Markdown

bosd commented Feb 10, 2026

@jaydeep32 Sure, I need to peek at other PR's how to do it all the time :)

Basically you need to add in the root of the repo folder a test-requirements.txt file.
If you want to depend on PR #1
The content should be:

odoo-addon-base_tier_validation @ git+https://github.com/OCA/tier-validation@refs/pull/1/head#subdirectory=base_tier_validation

I'll typically commit it in a separate commit "[DO NOT MERGE TEST REQUIREMENTS]"

Result:
OCB & Odoo tests should pass,
Runboat build finishes (So one can easily functional test this)
Red marker displayed about unreleased dependencies
image

source: https://github.com/OCA/oca-custom/blob/18.0/CONTRIBUTING.md#use-unreleased-dependency

Can you please update and apply this to your other pr's in this repo? 😉

@bosd
Copy link
Copy Markdown

bosd commented Feb 11, 2026

Can you please squash the administrative translation commits?
image

https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate
Then this one is good to go 👍

@jaydeep32 jaydeep32 force-pushed the 19.0-mig-purchase_tier_validation branch from 20032c3 to 3f34641 Compare March 30, 2026 21:18
@jaydeep32 jaydeep32 force-pushed the 19.0-mig-purchase_tier_validation branch from 3f34641 to 2a9e781 Compare March 30, 2026 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.