Skip to content

[17.0][ADD] fs_attachment_azure - #643

Open
grindtildeath wants to merge 2 commits into
OCA:17.0from
camptocamp:17.0-add-fs_attachment_azure
Open

[17.0][ADD] fs_attachment_azure#643
grindtildeath wants to merge 2 commits into
OCA:17.0from
camptocamp:17.0-add-fs_attachment_azure

Conversation

@grindtildeath

@grindtildeath grindtildeath commented Jul 13, 2026

Copy link
Copy Markdown

No description provided.

@OCA-git-bot OCA-git-bot added series:17.0 mod:fs_attachment_azure Module fs_attachment_azure labels Jul 13, 2026
@grindtildeath

grindtildeath commented Jul 13, 2026

Copy link
Copy Markdown
Author

Hello @lmignon
I reused most of the work you did on fs_attachment_s3 , so feel free to let me know how that looks for you 🙏

lmignon
lmignon requested changes Jul 15, 2026
View reviewed changes

@lmignon lmignon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grindtildeath Thank you for the proposal. Don't forget to run the tests locally before submitting your PR 😏 Some little typo remains to be fixed.

Comment thread fs_attachment_azure/tests/common.py Outdated
Comment thread fs_attachment_azure/tests/test_fs_attachment_s3.py Outdated
Comment thread fs_attachment_azure/tests/test_fs_attachment_s3.py Outdated
@grindtildeath
grindtildeath force-pushed the 17.0-add-fs_attachment_azure branch 2 times, most recently from 434daed to b84aa54 Compare July 15, 2026 19:13
ivantodorovich
ivantodorovich approved these changes Jul 20, 2026
View reviewed changes

@ivantodorovich ivantodorovich left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good

lmignon
lmignon approved these changes Jul 27, 2026
View reviewed changes

@lmignon lmignon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Code review Only)

@lmignon

lmignon commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

@grindtildeath I can't validate this code against Azure since I don't have access to an Azure environment. Once you've tested it on your side and it's ready to merge, just ping me.

@oca-cla-bot

oca-cla-bot Bot commented Aug 18, 2026 •
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@ivantodorovich
ivantodorovich force-pushed the 17.0-add-fs_attachment_azure branch from e640656 to e3723b0 Compare August 18, 2026 17:40
@ivantodorovich
ivantodorovich force-pushed the 17.0-add-fs_attachment_azure branch from e3723b0 to cd36d74 Compare September 9, 2026 16:47
@OCA-git-bot OCA-git-bot added the mod:fs_attachment_azure_environment Module fs_attachment_azure_environment label Sep 9, 2026
@ivantodorovich
ivantodorovich force-pushed the 17.0-add-fs_attachment_azure branch from cd36d74 to 1405953 Compare September 9, 2026 17:01
@ivantodorovich
ivantodorovich force-pushed the 17.0-add-fs_attachment_azure branch from 1405953 to 75c7b64 Compare September 24, 2026 14:51
@ivantodorovich

ivantodorovich commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Just rebased and cleaned commits

@ivantodorovich ivantodorovich mentioned this pull request Sep 24, 2026
Draft
@OCA-git-bot

OCA-git-bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@ivantodorovich ivantodorovich mentioned this pull request Sep 24, 2026
Draft
@lmignon

lmignon commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

@grindtildeath @ivantodorovich Once it's OK for you, I can merge it...

@ivantodorovich

ivantodorovich commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Thanks @lmignon !

First tests are going well :) we'll let you know when it's ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmignon lmignon lmignon approved these changes
+1 more reviewer
@ivantodorovich ivantodorovich ivantodorovich approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved mod:fs_attachment_azure_environment Module fs_attachment_azure_environment mod:fs_attachment_azure Module fs_attachment_azure ready to merge series:17.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@grindtildeath @lmignon @ivantodorovich @OCA-git-bot