[19.0] [MIG] sale_product_pack : migrate to 19.0 by apik-mgu · Pull Request #225 · OCA/product-pack

apik-mgu · 2025-10-20T07:38:55Z

No description provided.

[ADD] icon.png

add a Roadmap section to the readme for creating sale_stock_product_pack

If not done this way, we can experiment ORM problems with cache misses.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-pack-12.0/product-pack-12.0-sale_product_pack Translate-URL: https://translation.odoo-community.org/projects/product-pack-12-0/product-pack-12-0-sale_product_pack/

…ame place Previous technique was trying to access `pack_parent_line_id` related values that are not set due to the mangling on virtual records/creation phase, provoking an ORM error, but there's no need of such complex code, as we only need to set price_unit to 0 when preparing vals without the need of overriding other methods.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-pack-12.0/product-pack-12.0-sale_product_pack Translate-URL: https://translation.odoo-community.org/projects/product-pack-12-0/product-pack-12-0-sale_product_pack/

Translated using Weblate (Spanish) Currently translated at 86.7% (13 of 15 strings) Translation: product-pack-12.0/product-pack-12.0-sale_product_pack Translate-URL: https://translation.odoo-community.org/projects/product-pack-12-0/product-pack-12-0-sale_product_pack/es/

[UPD] Update sale_product_pack.pot sale_product_pack 12.0.1.0.2 Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-pack-12.0/product-pack-12.0-sale_product_pack Translate-URL: https://translation.odoo-community.org/projects/product-pack-12-0/product-pack-12-0-sale_product_pack/

It's helpfull to know directly if the sale order line is editable. If the sale order is edited from an api, onchange are not always triggered so having this field helps to raise an error. And it can be used to display in the view that the line is not editable.

[UPD] README.rst sale_product_pack 12.0.1.1.0 Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-pack-12.0/product-pack-12.0-sale_product_pack Translate-URL: https://translation.odoo-community.org/projects/product-pack-12-0/product-pack-12-0-sale_product_pack/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-pack-13.0/product-pack-13.0-sale_product_pack Translate-URL: https://translation.odoo-community.org/projects/product-pack-13-0/product-pack-13-0-sale_product_pack/

Currently translated at 42.1% (8 of 19 strings) Translation: product-pack-13.0/product-pack-13.0-sale_product_pack Translate-URL: https://translation.odoo-community.org/projects/product-pack-13-0/product-pack-13-0-sale_product_pack/nl/

Compatibility module between sale_product_pack and website_sale TT30385

…onsistent prices in some cases. TT32539

nicolascol · 2025-11-06T10:13:50Z

LGTM functional review.
I think the mention in contributors is incorrect, it's only a migration.

@apik-mgu @pedrobaeza

pedrobaeza · 2025-11-06T19:45:13Z

/ocabot migration sale_product_pack

Some reviews are needed, and one must come from PSC / maintainer

apik-mgu · 2025-11-07T08:17:14Z

Hello Pedro, Could you clarify your request? I don't quite understand what I'm supposed to do. Thank you in advance for your reply. Cordialement, Michel GUIHENEUF Consultant Odoo 02 57 62 02 56 ***@***.*** https://apik.cloud Nautiparc 16 rue de l'île de la jument, 56870, Baden

…

________________________________ De : Pedro M. Baeza ***@***.***> Envoyé : jeudi 6 novembre 2025 20:45 À : OCA/product-pack ***@***.***> Cc : Michel GUIHENEUF ***@***.***>; Mention ***@***.***> Objet : Re: [OCA/product-pack] [19.0] [MIG] sale_product_pack : migrate to 19.0 (PR #225) [https://avatars.githubusercontent.com/u/7165771?s=20&v=4]pedrobaeza left a comment (OCA/product-pack#225)<#225 (comment)> /ocabot migration sale_product_pack Some reviews are needed, and one must come from PSC / maintainer — Reply to this email directly, view it on GitHub<#225 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ARBM22TJMZBM4JLZMA5XLNT33OQN7AVCNFSM6AAAAACJU4XKZ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTIOJZGEYTQOBZGU>. You are receiving this because you were mentioned.Message ID: ***@***.***>

OCA-git-bot · 2025-11-07T08:17:26Z

Sorry @apik-mgu you are not allowed to mark the addon to be migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

pedrobaeza · 2025-11-07T08:18:11Z

https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#review

lef-adhoc

LGTM

lef-adhoc · 2025-11-13T19:10:20Z

@pedrobaeza Could you merge please?

pedrobaeza · 2025-11-13T19:15:23Z

sale_product_pack/pyproject.toml

 requires = ["whool"]
 build-backend = "whool.buildapi"
+
+[project]


This entry sounds weird

What about this?

Désolé mais je ne comprends pas ce que vous entendez réellement.
Merci

I mean this modification should be out.

I agree with @pedrobaeza , we should not modify the pyproject.toml

sale_product_pack/readme/CONTRIBUTORS.md

sale_product_pack/models/product_pack_line.py

sale_product_pack/tests/common.py

apik-mgu · 2025-11-24T12:38:45Z

@pedrobaeza
Correction made.
Have a good day.

yankinmax

pre-approve considering changes requested

lef-adhoc · 2025-12-17T20:49:28Z

@pedrobaeza Hi, what would be required to merge this PR?

pedrobaeza · 2025-12-18T07:20:33Z

sale_product_pack/models/sale_order.py

+class SaleOrder(models.Model):
+    _inherit = "sale.order"
+
+    def copy(self, default=None):


Copy now may return a recordset, so this is not correct (this applies also to 18).

apik-mgu · 2025-12-18T08:34:48Z

Cela a déjà été fait. Cordialement, Michel GUIHENEUF Consultant Odoo 02 57 62 02 56 ***@***.*** https://apik.cloud Nautiparc 16 rue de l'île de la jument, 56870, Baden

________________________________ De : Pedro M. Baeza ***@***.***> Envoyé : jeudi 18 décembre 2025 08:19 À : OCA/product-pack ***@***.***> Cc : Michel GUIHENEUF ***@***.***>; Mention ***@***.***> Objet : Re: [OCA/product-pack] [19.0] [MIG] sale_product_pack : migrate to 19.0 (PR #225) @pedrobaeza commented on this pull request.

________________________________ In sale_product_pack/pyproject.toml<#225 (comment)>:

@@ -1,3 +1,10 @@

[build-system] requires = ["whool"] build-backend = "whool.buildapi" + +[project] I mean this modification should be out. — Reply to this email directly, view it on GitHub<#225 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ARBM22WYXCGIPY35WUPKDOT4CJIRJAVCNFSM6AAAAACJU4XKZ6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTKOJRGE2DSMJWGU>. You are receiving this because you were mentioned.Message ID: ***@***.***>

apik-mgu · 2025-12-18T08:58:10Z

J'ai fait une correction semblable à ce que fait Odoo. Si cela n'est pas suffisant, pouvez-vous m'expliquer clairement ce que vous attendez comme correction. Merci Cordialement, Michel GUIHENEUF Consultant Odoo 02 57 62 02 56 ***@***.*** https://apik.cloud Nautiparc 16 rue de l'île de la jument, 56870, Baden

________________________________ De : Pedro M. Baeza ***@***.***> Envoyé : jeudi 18 décembre 2025 08:21 À : OCA/product-pack ***@***.***> Cc : Michel GUIHENEUF ***@***.***>; Mention ***@***.***> Objet : Re: [OCA/product-pack] [19.0] [MIG] sale_product_pack : migrate to 19.0 (PR #225) @pedrobaeza commented on this pull request.

________________________________ In sale_product_pack/models/sale_order.py<#225 (comment)>:

@@ -0,0 +1,66 @@

+# Copyright 2019 Tecnativa - Ernesto Tejeda +# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). +from odoo import api, models +from odoo.exceptions import UserError + + +class SaleOrder(models.Model): + _inherit = "sale.order" + + def copy(self, default=None): Copy now may return a recordset, so this is not correct (this applies also to 18). — Reply to this email directly, view it on GitHub<#225 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ARBM22VAQUTBN2H7UKKT4E34CJIXRAVCNFSM6AAAAACJU4XKZ6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTKOJRGE2TIMRRGY>. You are receiving this because you were mentioned.Message ID: ***@***.***>

pedrobaeza · 2025-12-18T15:38:35Z

Please don't use other language except English. The change is not correct, as it's still comparing == self, being self probably a multi-record, so the code is not valid. Check also the rest of the comments.

apik-mgu · 2025-12-22T07:49:47Z

Modification made

ivantodorovich · 2025-12-22T16:15:30Z

sale_product_pack/models/sale_order.py

+                lambda x, order=record: x.pack_parent_line_id.order_id == order
+            )
+            if pack_copied_lines:
+                pack_copied_lines.unlink()


I think you can implement this in the new _get_copiable_order_lines hook now, and so it's filtered directly in the creation values provided by copy_data

much-filipe-colaco · 2026-02-23T16:27:16Z

Any news on this migration? Is it planned to be released soon?

FrancoMaxime · 2026-03-12T13:13:55Z

I make another pull request with the changes asked from @pedrobaeza and @ivantodorovich

see #244

ernestotejeda and others added 30 commits October 16, 2025 17:32

[ADD] sale_product_pack: new module

6c71036

[UPD] README.rst + [ADD] icon.png

c5be2f1

[ADD] icon.png

[UPD] Update sale_product_pack.pot

26b8cb2

[IMP] sale_product_pack: add a Roadmap section to the readme

bf22a20

add a Roadmap section to the readme for creating sale_stock_product_pack

[FIX] sale_product_pack: Unlink pack children lines before

aaed3c7

If not done this way, we can experiment ORM problems with cache misses.

[UPD] Update sale_product_pack.pot

a321563

Update translation files

3c9bef5

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-pack-12.0/product-pack-12.0-sale_product_pack Translate-URL: https://translation.odoo-community.org/projects/product-pack-12-0/product-pack-12-0-sale_product_pack/

Added translation using Weblate (Portuguese)

5e8a290

[UPD] Update sale_product_pack.pot

8b2bba3

Update translation files

bb6c4ae

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-pack-12.0/product-pack-12.0-sale_product_pack Translate-URL: https://translation.odoo-community.org/projects/product-pack-12-0/product-pack-12-0-sale_product_pack/

Allow to update product_uom_qty after sale is confirmed

54ad49b

[UPD] Update sale_product_pack.pot

e51978a

Added translation using Weblate (French)

da61a65

[IMP] sale_product_pack: black, isort, prettier

4c7df71

[MIG] sale_product_pack: Migration to 13.0

6ab5874

[MIG] sale_product_pack: Migration to 13.0 (fix order line deleting)

10d21d3

[UPD] Update sale_product_pack.pot

0eedb78

[UPD] README.rst

9b005ea

Update translation files

1e21981

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-pack-13.0/product-pack-13.0-sale_product_pack Translate-URL: https://translation.odoo-community.org/projects/product-pack-13-0/product-pack-13-0-sale_product_pack/

[FIX] sale_product_pack: Missing write result

d506385

Added translation using Weblate (Dutch)

a7dfe2f

Translated using Weblate (Dutch)

1d4524b

Currently translated at 42.1% (8 of 19 strings) Translation: product-pack-13.0/product-pack-13.0-sale_product_pack Translate-URL: https://translation.odoo-community.org/projects/product-pack-13-0/product-pack-13-0-sale_product_pack/nl/

[ADD] website_sale_product_pack: New module

e6da814

Compatibility module between sale_product_pack and website_sale TT30385

[FIX] sale_product_pack: Add pricelist to the sale order to avoid inc…

ba229f2

…onsistent prices in some cases. TT32539

sale_product_pack 13.0.1.0.2

5916e2f

apik-mgu force-pushed the 19.0-mig-sale_product_pack branch 2 times, most recently from 1d36ece to f1fdf43 Compare November 6, 2025 07:58

OCA-git-bot added this to the 19.0 milestone Nov 6, 2025

lef-adhoc approved these changes Nov 7, 2025

View reviewed changes

pedrobaeza requested changes Nov 13, 2025

View reviewed changes

apik-mgu force-pushed the 19.0-mig-sale_product_pack branch from f1fdf43 to de527a1 Compare November 24, 2025 12:35

yankinmax approved these changes Dec 8, 2025

View reviewed changes

apik-mgu force-pushed the 19.0-mig-sale_product_pack branch from de527a1 to 4889f06 Compare December 9, 2025 08:58

pedrobaeza reviewed Dec 18, 2025

View reviewed changes

apik-mgu force-pushed the 19.0-mig-sale_product_pack branch 2 times, most recently from b4a5619 to 821c6b3 Compare December 18, 2025 08:54

[MIG] sale_product_pack: Migration to 19.0

1b614f5

apik-mgu force-pushed the 19.0-mig-sale_product_pack branch from 821c6b3 to 1b614f5 Compare December 22, 2025 07:26

ivantodorovich reviewed Dec 22, 2025

View reviewed changes

FrancoMaxime mentioned this pull request Mar 12, 2026

[19.0] [MIG] sale_product_pack : migrate to 19.0 #244

Open

pedrobaeza closed this Mar 12, 2026

Uh oh!

Conversation

apik-mgu commented Oct 20, 2025

Uh oh!

nicolascol commented Nov 6, 2025

Uh oh!

pedrobaeza commented Nov 6, 2025

Uh oh!

apik-mgu commented Nov 7, 2025 via email

Uh oh!

OCA-git-bot commented Nov 7, 2025

Uh oh!

pedrobaeza commented Nov 7, 2025

Uh oh!

lef-adhoc left a comment

Choose a reason for hiding this comment

Uh oh!

lef-adhoc commented Nov 13, 2025

Uh oh!

pedrobaeza Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

pedrobaeza Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

apik-mgu Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

pedrobaeza Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

FrancoMaxime Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

apik-mgu commented Nov 24, 2025

Uh oh!

yankinmax left a comment

Choose a reason for hiding this comment

Uh oh!

lef-adhoc commented Dec 17, 2025

Uh oh!

pedrobaeza Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

apik-mgu commented Dec 18, 2025 via email

Uh oh!

apik-mgu commented Dec 18, 2025 via email

Uh oh!

pedrobaeza commented Dec 18, 2025

Uh oh!

apik-mgu commented Dec 22, 2025

Uh oh!

ivantodorovich Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

much-filipe-colaco commented Feb 23, 2026

Uh oh!

FrancoMaxime commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

FrancoMaxime commented Mar 12, 2026 •

edited

Loading