Repository navigation
[16.0][FIX] pms: a check-in confirms the room assignment - #470
Merged
OCA-git-bot merged 1 commit intoNov 2, 2026
Merged
Conversation
|
All commit authors signed the Contributor License Agreement. |
DarioLodeiros
force-pushed
the
16.0-fix-pms-checkin-clears-to-assign
branch
from
November 2, 2026 14:57
c0a890a to
b083d87
Compare
Reservations imported from a channel are created with an automatic room and flagged as pending assignment (to_assign) until someone at the front desk confirms it. Until now that flag survived the check-in, so a reservation with a guest already on board kept showing as "pending assignment" in the PMS: the colour meant to attract attention to a new booking was hiding the fact that the room was occupied, and the staff could move the guest to another room without noticing. A guest sleeping in the room settles the assignment. action_on_board now clears to_assign together with the state change to onboard. Originally proposed in commitsun#234.
DarioLodeiros
force-pushed
the
16.0-fix-pms-checkin-clears-to-assign
branch
from
November 2, 2026 15:45
b083d87 to
76ce34f
Compare
Member
Author
|
/ocabot merge patch |
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
Congratulations, your PR was merged at fe985a6. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings to 16.0 the fix proposed by @davidpachecop in commitsun#234.
What happens today
Reservations imported from a channel arrive with an automatic room and the
to_assignflag on, so the front desk reviews and confirms the assignment. That flag survives the check-in. A reservation with a guest already on board keeps showing as pending assignment, and in the app that colour takes precedence over the "in house" one, both on the planning and on the reservation card.So the staff can move a guest who is already in the room to another one without noticing, and the original room is then free to be sold again.
The change
A guest sleeping in the room settles the assignment.
action_on_boardnow clearsto_assigntogether with the state change toonboard.pms/models/pms_checkin_partner.py: the state write now also setsto_assign = False.pms/tests/test_pms_checkin_partner.py:test_onboard_reservation_clears_to_assign.to_assignis only read to flag and colour reservations, so nothing else reacts to the change.