Skip to content

[17.0][ADD] product_margin_report_landed_costs - #247

Open
edescalona wants to merge 1 commit into
OCA:17.0from
BinhexTeam:17.0-add-product_margin_report_landed_costs
Open

[17.0][ADD] product_margin_report_landed_costs#247
edescalona wants to merge 1 commit into
OCA:17.0from
BinhexTeam:17.0-add-product_margin_report_landed_costs

Conversation

@edescalona

@edescalona edescalona commented Aug 5, 2025

Copy link
Copy Markdown

@BinhexTeam

Add the landed costs associated with the product to the Product Margins report.

@edescalona
edescalona force-pushed the 17.0-add-product_margin_report_landed_costs branch 4 times, most recently from fd3dd39 to 0c197cc Compare August 5, 2025 18:50
@edescalona
edescalona marked this pull request as ready for review August 5, 2025 18:59
rrebollo
rrebollo approved these changes Sep 9, 2025
View reviewed changes

@rrebollo rrebollo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pure Code Review. LGTM!!! I do think functional review is critical on this kind of addons. Great contribution.

Comment thread product_margin_report_landed_costs/tests/test_product_margin_report_landed_costs.py Outdated
Comment thread product_margin_report_landed_costs/tests/test_product_margin_report_landed_costs.py Outdated
@rrebollo

rrebollo commented Sep 9, 2025

Copy link
Copy Markdown

I don't have extensive knowledge of stock valuation methodologies, but I am aware of the key differences between Anglo-Saxon and Continental accounting principles. Perhaps you could mention any prerequisites regarding those accounting standards in addon's documentation.

@edescalona
[ADD] product_margin_report_landed_costs: Add the landed costs associ…
6ed45cf 
…ated with the product to the Product Margins report.
@edescalona
edescalona force-pushed the 17.0-add-product_margin_report_landed_costs branch from 0c197cc to 6ed45cf Compare September 11, 2025 19:14
@edescalona

edescalona commented Sep 11, 2025

Copy link
Copy Markdown
Author

ping @rrebollo

@rrebollo

rrebollo commented Sep 12, 2025

Copy link
Copy Markdown

Nice job @edescalona

@edescalona

edescalona commented Sep 24, 2025

Copy link
Copy Markdown
Author

ping @Christian-RB

@github-actions

github-actions Bot commented Jan 25, 2026

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 25, 2026
@github-actions github-actions Bot closed this Mar 1, 2026
@edescalona

edescalona commented Oct 21, 2026

Copy link
Copy Markdown
Author

Hi @jelenapoblet , could you try to reopen this PR?

@jelenapoblet

jelenapoblet commented Oct 21, 2026

Copy link
Copy Markdown

You got it bro!

@jelenapoblet jelenapoblet reopened this Oct 21, 2026
@OCA-git-bot OCA-git-bot added series:17.0 mod:product_margin_report_landed_costs Module product_margin_report_landed_costs labels Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@rrebollo rrebollo rrebollo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

mod:product_margin_report_landed_costs Module product_margin_report_landed_costs series:17.0 stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@edescalona @rrebollo @jelenapoblet @OCA-git-bot