Repository navigation
Conversation
Contributor
|
Hi @etobella, |
SilvioC2C
approved these changes
Oct 12, 2026
SilvioC2C
left a comment
Contributor
There was a problem hiding this comment.
I would keep the old behavior for backward compatibility, possibly logging a deprecation warning, and remove it completely in v20.0; not blocking though.
Contributor
Author
The component module keeps the old behavior. Nobody is using the handler model yet -> I don't want to support legacy mode for it 😉 |
simahawk
force-pushed
the
18-use-webservice-endpoint
branch
from
October 16, 2026 15:09
1cbc6d8 to
9ec7908
Compare
If the exchange type has a webservice_endpoint_id set, the send handler uses it directly; otherwise configuration comes from the exchange type's advanced settings, under execution_model.send.webservice, as before. send_as_bytes is now a proper field (webservice_send_as_bytes), visible only when the webservice handler is selected (webservice_send_enabled).
simahawk
force-pushed
the
18-use-webservice-endpoint
branch
from
October 16, 2026 15:17
9ec7908 to
35f4d62
Compare
simahawk
force-pushed
the
18-use-webservice-endpoint
branch
from
October 16, 2026 15:44
35f4d62 to
237db9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on
[18.0][IMP] webservice_core: add configurable endpoints web-api#175
edi.webservice.sendhandler: now dispatches through awebservice.endpoint(mandatory) instead of a raw
method/pargsYAML config —methodis no longeraccepted in YAML.
edi.exchange.type: newwebservice_endpoint_id,webservice_send_as_bytesfields, plus a computed
webservice_send_enabled(checkssend_model_idinheritsedi.webservice.sendvia registry) driving the form view.Migration helper (
hooks.py, opt-in, not auto-run):migrate_component_based_exchange_types/migrate_exchange_typeconvert exchange types off the legacycomponent-based sendonto the new handler — auto-creates the endpoint, splits
url_paramsbetweenpath-placeholders and querystring, moves
send_as_bytesto the new field.Tests and README updated accordingly.