Skip to content

[15.0][IMP] website_sale_hide_price: add an option to show website_hide_price_message to public users#1224

Open
smorita7749 wants to merge 1 commit into
OCA:15.0from
qrtl:15.0-imp-website_sale_hide_price
Open

[15.0][IMP] website_sale_hide_price: add an option to show website_hide_price_message to public users#1224
smorita7749 wants to merge 1 commit into
OCA:15.0from
qrtl:15.0-imp-website_sale_hide_price

Conversation

@smorita7749
Copy link
Copy Markdown

@smorita7749 smorita7749 commented May 26, 2026

Currently, non-logged-in users cannot see the website_hide_price_message, so they have no way to understand why product prices are hidden.

This improvement adds a website-level option "Show hidden price message to public users". When enabled, the website_hide_price_message is also shown to public (non-logged-in) users.
@qrtl QT6775

@OCA-git-bot OCA-git-bot added mod:website_sale_hide_price Module website_sale_hide_price series:15.0 labels May 26, 2026
Copy link
Copy Markdown
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, but maybe @chienandalu could explain the rationale of the original design which was introduced in #639?

@chienandalu
Copy link
Copy Markdown
Member

Looks reasonable to me, but maybe @chienandalu could explain the rationale of the original design which was introduced in #639?

The idea was something along these lines: when you're visiting the site as public user, you can't see any price in the eCommerce, but when you do it as portal user, only some selected products have their prices hidden (for commercial reasons or whatever) and the site manager can show an extra message explaining why.

This was in a b2b scenario where these prices are very strategic

@smorita7749 smorita7749 changed the title [15.0][IMP] website_sale_hide_price: show website_hide_price_message to non-logged-in users [15.0][IMP] website_sale_hide_price: add an option to show website_hide_price_message to public users May 29, 2026
@smorita7749 smorita7749 marked this pull request as draft May 29, 2026 09:38
@smorita7749 smorita7749 force-pushed the 15.0-imp-website_sale_hide_price branch 3 times, most recently from e981946 to 7b627d9 Compare June 2, 2026 14:10
@smorita7749
Copy link
Copy Markdown
Author

Looks reasonable to me, but maybe @chienandalu could explain the rationale of the original design which was introduced in #639?

The idea was something along these lines: when you're visiting the site as public user, you can't see any price in the eCommerce, but when you do it as portal user, only some selected products have their prices hidden (for commercial reasons or whatever) and the site manager can show an extra message explaining why.

This was in a b2b scenario where these prices are very strategic

Thank you for your detailed explanation!
To preserve this b2b behavior, the new option is disabled by default, so nothing changes for existing sites: public users still don't see the message, and the message is shown only when the option is explicitly enabled.

Could you please take a look when you have time? Thanks a lot.

Thank you for your support! @yostashiro

@smorita7749 smorita7749 marked this pull request as ready for review June 2, 2026 14:12
@smorita7749 smorita7749 force-pushed the 15.0-imp-website_sale_hide_price branch 3 times, most recently from 875dc13 to 33ed512 Compare June 3, 2026 03:21
@smorita7749 smorita7749 force-pushed the 15.0-imp-website_sale_hide_price branch from 33ed512 to 5f2b97b Compare June 3, 2026 04:04
Copy link
Copy Markdown

@AungKoKoLin1997 AungKoKoLin1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG 👍

@OCA-git-bot
Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants