Skip to content

[19.0][MIG] agreement_sale: Migration to 19.0#100

Open
Vang-NguyenPhu wants to merge 24 commits intoOCA:19.0from
komit-consulting:19.0-mig-agreement_sale
Open

[19.0][MIG] agreement_sale: Migration to 19.0#100
Vang-NguyenPhu wants to merge 24 commits intoOCA:19.0from
komit-consulting:19.0-mig-agreement_sale

Conversation

@Vang-NguyenPhu
Copy link
Copy Markdown

@Vang-NguyenPhu Vang-NguyenPhu commented Jan 15, 2026 •
edited
Loading

Depends on:

@Vang-NguyenPhu Vang-NguyenPhu force-pushed the 19.0-mig-agreement_sale branch from d37cb6f to b59b0ab Compare January 15, 2026 09:47
@Vang-NguyenPhu Vang-NguyenPhu mentioned this pull request Jan 15, 2026
Open
5 tasks
@leemannd
Copy link
Copy Markdown

leemannd commented Jan 19, 2026

Hello @Vang-NguyenPhu is it possible to squash a bit the translation/administrative commits?

liweijie0812 and others added 19 commits January 23, 2026 16:26
@liweijie0812 @Vang-NguyenPhu
Added translation using Weblate (Chinese (Simplified))
3f7706a
@gurneyalex @Vang-NguyenPhu
[IMP] move some notions from agreement_legal to agreement
50b617f 
we move the is_template field definition and the agreement.type model from
the agreement_legal module to the agreement module.

The fields are not displayed by default, unless the feature is enabled through a
technical feature group, this is configurable in the agreement_sale module (because agreement
in itself has no UI, and agreement_legal enables the feature by default)
@Vang-NguyenPhu
[MIG][13.0] agreemnt_sale + black
fcc591b
@Vang-NguyenPhu
[IMP] agreement_sale: black, isort, prettier
dfde73d
@Vang-NguyenPhu
[MIG] agreement_sale: Migration to 14.0
e1b51cb
@ibuioli @Vang-NguyenPhu
Added translation using Weblate (Spanish (Argentina))
1607c73
@weblate @Vang-NguyenPhu
Update translation files
2dec8d0 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: contract-14.0/contract-14.0-agreement_sale
Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-agreement_sale/
@Ivorra78 @Vang-NguyenPhu
Added translation using Weblate (Spanish)
6a54870
@imlopes @Vang-NguyenPhu
[IMP] agreement_sale: pre-commit auto fixes
a4a7420
@imlopes @Vang-NguyenPhu
[17.0][MIG] agreement_sale: Migration to 17.0
460aa32
@weblate @Vang-NguyenPhu
Update translation files
28851db 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: agreement-17.0/agreement-17.0-agreement_sale
Translate-URL: https://translation.odoo-community.org/projects/agreement-17-0/agreement-17-0-agreement_sale/
@mymage @Vang-NguyenPhu
Added translation using Weblate (Italian)
f63642b
@Vang-NguyenPhu
[IMP] agreement_sale: pre-commit execution
7c7aa23
@Vang-NguyenPhu
[MIG] agreement_sale: Migration to 18.0
d743cb1
@Vang-NguyenPhu
[UPD] Update agreement_sale.pot
6a6ab84
@jakobkrabbe @Vang-NguyenPhu
Added translation using Weblate (Swedish)
9622033
@ROBBYHOOD9 @Vang-NguyenPhu
[IMP] agreement_sale: fix when upgrade agreement_sale menu Agreements…
6e61820 
… is disappear
@etobella @Vang-NguyenPhu
[IMP] agreement_sale: Update logo
05015c8
@Vang-NguyenPhu
[IMP] agreement_sale: pre-commit auto fixes
167a5ee
@Vang-NguyenPhu Vang-NguyenPhu force-pushed the 19.0-mig-agreement_sale branch from b59b0ab to 5d4bfbc Compare January 23, 2026 09:27
@Vang-NguyenPhu
Copy link
Copy Markdown
Author

Vang-NguyenPhu commented Jan 23, 2026

Hello @Vang-NguyenPhu is it possible to squash a bit the translation/administrative commits?

All good now, please help to review. Thank you @leemannd

@Vang-NguyenPhu Vang-NguyenPhu force-pushed the 19.0-mig-agreement_sale branch from 5d4bfbc to 231eef2 Compare January 23, 2026 09:35
@Vang-NguyenPhu
Copy link
Copy Markdown
Author

Vang-NguyenPhu commented Jan 23, 2026 •
edited
Loading

Hi @leemannd Do you know how to fix this error? It seems like OCA changed the behavior of adding depends PR, right? Could you please guide me on how to fix this? Thank you.

image

@leemannd
Copy link
Copy Markdown

leemannd commented Jan 23, 2026

Hello, this is due because you depend on a non merged PR. You should add a test-requirements.txt file.

There is an example in -> OCA/delivery-carrier@c9f657b

@Vang-NguyenPhu Vang-NguyenPhu force-pushed the 19.0-mig-agreement_sale branch 3 times, most recently from e2ba0ff to 7a7ef49 Compare January 26, 2026 02:36
@Vang-NguyenPhu
Copy link
Copy Markdown
Author

Vang-NguyenPhu commented Jan 26, 2026

Hi @leemannd , I did exactly like the example e2ba0ff, but pipline still fails with the same result. Could you please help me with this? Thank you

@Vang-NguyenPhu Vang-NguyenPhu force-pushed the 19.0-mig-agreement_sale branch from 7a7ef49 to c8233d0 Compare February 4, 2026 08:08
Quan-nhm
Quan-nhm approved these changes Feb 27, 2026
View reviewed changes
Copy link
Copy Markdown

@Quan-nhm Quan-nhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's LGTM for functional test and code review. but it would be greate if you could refactor the comment as well.

huan-tq
huan-tq approved these changes Mar 13, 2026
View reviewed changes
Copy link
Copy Markdown

@huan-tq huan-tq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function Tested and it's LGTM

@Vang-NguyenPhu Vang-NguyenPhu force-pushed the 19.0-mig-agreement_sale branch from c8233d0 to 0dd9903 Compare March 27, 2026 09:23
@Vang-NguyenPhu Vang-NguyenPhu requested a review from Quan-nhm March 27, 2026 09:25
@Vang-NguyenPhu Vang-NguyenPhu force-pushed the 19.0-mig-agreement_sale branch 2 times, most recently from b259e8d to f7b272f Compare March 27, 2026 09:38
@Vang-NguyenPhu Vang-NguyenPhu force-pushed the 19.0-mig-agreement_sale branch from f7b272f to 3926f21 Compare March 27, 2026 09:45
hieulucky111
hieulucky111 approved these changes Apr 3, 2026
View reviewed changes
Copy link
Copy Markdown

@hieulucky111 hieulucky111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review. LGTM

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Apr 3, 2026

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Quan-nhm Quan-nhm Awaiting requested review from Quan-nhm

2 more reviewers

@hieulucky111 hieulucky111 hieulucky111 approved these changes

@huan-tq huan-tq huan-tq approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.