Skip to content

[17.0][FIX] repair: orders on a location without warehouse kept the temporary records #6062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SamyShaawat wants to merge 1 commit into
base: 17.0
Choose a base branch
from
Open

[17.0][FIX] repair: orders on a location without warehouse kept the temporary records #6062

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions openupgrade_scripts/scripts/repair/17.0.1.0/post-migration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,29 @@ def fill_repair_picking_type(env):
WHERE ro.location_id = sl.id
""",
)
# Repair orders whose location doesn't belong to any warehouse
# (e.g. a customer location) still point to the temporary records,
# so fall back to the first warehouse of their company
openupgrade.logged_query(
env.cr,
"""
UPDATE repair_order ro
SET picking_type_id = sw.repair_type_id,
location_dest_id = spt.default_location_dest_id,
parts_location_id = spt.default_remove_location_dest_id,
recycle_location_id = spt.default_recycle_location_dest_id
FROM stock_picking_type tmp, (
SELECT DISTINCT ON (company_id) company_id, repair_type_id
FROM stock_warehouse
WHERE repair_type_id IS NOT NULL
ORDER BY company_id, id
) sw
JOIN stock_picking_type spt ON spt.id = sw.repair_type_id
WHERE tmp.name->>'en_US' = 'SPT Repair OpenUpgrade'
AND ro.picking_type_id = tmp.id
AND ro.company_id = sw.company_id
""",
)
# Remove the temporary location and picking type
# created during the migration
env["stock.location"].search(
Expand Down