Skip to content

[13.0][OU-FIX] l10n_es: keep the accounts of group taxes #6047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pedrobaeza merged 1 commit into from
Oct 1, 2026
Merged

[13.0][OU-FIX] l10n_es: keep the accounts of group taxes #6047

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions addons/l10n_es/migrations/13.0.4.0/post-migration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,26 @@ def use_new_taxes_and_repartition_lines_on_move_lines(env):
FROM account_tax
WHERE id IN %%s""" % column, (tuple(tax_ids), ),
)
# A group tax holds no account: its children do. Each tax repartition
# line takes the account of its child's one, matched as the move
# lines are matched to their repartition line below.
for tax_column in ("invoice_tax_id", "refund_tax_id"):
openupgrade.logged_query(
env.cr, sql.SQL("""
UPDATE account_tax_repartition_line atrl2
SET account_id = atrl.account_id
FROM account_tax_repartition_line atrl
JOIN account_tax at ON atrl.{column} = at.id
JOIN account_tax_filiation_rel rel ON rel.child_tax = at.id
WHERE atrl2.{column} = rel.parent_tax
AND atrl2.repartition_type = 'tax'
AND atrl.repartition_type = 'tax'
AND SIGN(at.amount) = SIGN(atrl2.factor_percent)
AND atrl2.account_id IS NULL
AND rel.parent_tax IN %s
""").format(column=sql.Identifier(tax_column)),
(tuple(tax_ids), ),
)
if children_tax_ids:
# assure children taxes are not parent taxes
openupgrade.logged_query(
Expand Down
Loading