Skip to content

Fix version option #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LucindaLanoy merged 2 commits into from
Mar 30, 2026
Merged

Fix version option #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fac725e
make version option work again
LucindaLanoy Mar 30, 2026
42a8644
Add version flag to dotnet command in workflow
LucindaLanoy Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/Check-Cyz2Json.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,5 +98,5 @@ jobs:
if [ "${{ matrix.os }}" == "macos-latest" ]; then
export DYLD_FALLBACK_LIBRARY_PATH=$(dirname $dll_path)
fi
dotnet $dll_path "$file" --imaging-set-information --image-processing --output $exmpl_path/"$bn".json
dotnet $dll_path "$file" --imaging-set-information --image-processing --output $exmpl_path/"$bn".json --version
echo "File successfully converted !"
7 changes: 6 additions & 1 deletion Cyz2Json/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ static void Main(string[] args)
var outputOption = new Option<FileInfo>( name: "--output", description: "JSON output file");
var rawOption = new Option<bool>( name: "--raw", description: "Do not apply the moving weighted average filtering algorithm to pulse shapes. Export raw, unsmoothed data.");
var metadatagreedyOption = new Option<bool>( name: "--metadatagreedy", description: "Save all possible measurement settings with your file (default: true)", getDefaultValue: () => true);
var versionOption = new Option<bool>( name: "-V", description: "Display version information");
var versionOption = new Option<bool>( name: "--version", description: "Display version information");
var setInformationOption = new Option<bool>( name: "--imaging-set-information", description: "Export set information for imaging" );
var setDefinitionOverride = new Option<FileInfo>( name: "--imaging-set-definition", description: "File with set definitions, overrides the definitions stored in the file." ).ExistingOnly();

Expand Down Expand Up @@ -116,6 +116,11 @@ static void Main(string[] args)
MarginBase=imgMarginBase, MarginPercentage=imgMarginPercentage, ExtendObjectDetection=imgExtendObjectDetection};


if (version)
{
HandleVersion();
return;
}
Convert(input, output, raw, metadatagreedy, setInformation, setDefinitionFile, imgOpts);
}
foreach (ParseError parseError in parseResult.Errors)
Expand Down