Repository navigation
fix(cli): accept --runtime hermes_moa in the provider registry - #161
Open
eastagiletracker wants to merge 1 commit into
Open
eastagiletracker wants to merge 1 commit into
eastagiletracker wants to merge 1 commit into
Conversation
runtime_registry.py added the hermes_moa runtime, but the CLI's PROVIDER_IDS was never extended, so `speca run --runtime hermes_moa` exited 2 with "unknown runtime" before spawning the orchestrator, and the provider-id drift test in providers.registry.test.ts was red. Hermes owns the credential pool and the proxy, so the CLI descriptor has no env keys to check; the hermes-on-PATH probe stays on the Python side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes fixing
speca run --runtime hermes_moabeing rejected by the CLI because its provider registry never picked up thehermes_moaruntime. We include this PR work along with a full history of your repo at https://eastagiletracker.com/projects/1000. You can sign in with your GitHub ID to claim ownership of the project.What was wrong
scripts/orchestrator/runtime_registry.pyregistershermes_moa(it is in theRuntimeIdliteral, inREGISTRY, and inrun_phase.py --runtimechoices), butPROVIDER_IDSincli/src/lib/providers/registry.tswas never extended with it. Sincespeca runvalidates--runtimeagainst that list before spawning, the Mixture-of-Agents runtime is unreachable from the CLI. Reproduced onmain(d173893) with the built CLI from an empty workspace:The drift test that exists to catch exactly this is red on
maintoo, and it is what failscli-cion the open PR branches (for example thefix/review-verdict-vocabulary-132run):The change
cli/src/lib/providers/registry.ts: appendhermes_moatoPROVIDER_IDS(same order as the Python literal) and add its descriptor. Hermes owns the credential pool and the proxy, so, like the other CLI-managed runtimes, there is no speca-side env key to check; the "ishermeson PATH" probe stays in_probe_hermes_moaon the Python side.cli/test/providers.registry.test.ts:hermes_moajoins the "needs no env credentials" cases.cli/test/run.command.test.ts: new case assertingrunRunCommandforwardsruntime: "hermes_moa"into the spawn options without an "unknown runtime" error.Purely additive: no existing id, descriptor, or default changes, so callers that pass any of the other runtimes (or none) behave exactly as before.
Red before green
With only the
registry.tschange stashed (tests kept), three tests fail:With the fix applied,
cd cli && npx vitest rungoes from 1 failed / 468 passed onmainto 471 passed, 0 failed;npm run typecheckandnpm run buildare clean. No Python files changed (uv run python3 -m pytest tests/: 855 passed, 4 skipped before and after). The rebuilt CLI now hands--runtime hermes_moato the orchestrator, which runs through to its normal phase dependency check in an empty workspace.How this was managed
This work was tracked as a story at https://eastagiletracker.com/projects/1000/stories/1362395 on a board imported from this repo's issues and pull requests: https://eastagiletracker.com/projects/1000
If you'd rather not receive contributions like this, reply
no-more-prson this pull request and we won't open any further ones on your repositories.Lawrence W. Sinclair
CEO / East Agile
linkedin.com/in/lwsinclair/
eastagile.com