[Nurozen]

Upstream checkpoint cd8c2c5

True merge of pingdotgg/t3code through cd8c2c593275147d7f253ca0fd93dbe6088237b1 (452 upstream first-parent commits after accepted 16918b57d675, pingdotgg#20967 onward) into Lecturn main 7ce4e260b283 (commit b32b5409), then a merge of current main 12c3dc37 (commit 18f0d00a), then review and evidence fixes. 253 upstream conflicts and 31 main conflicts resolved into Lecturn's architecture and identity.

What changes

• MCP Apps and visual replies: an MCP App enters full screen only right after a real tap (fix(client): MCP apps can no longer trap you in full screen; it opens only after a tap pingdotgg/t3code#18548), on web, mobile and Lecturn Apps cards. Full-screen visual replies keep a 16 px gap from the frame edge (fix(web): full-screen visual replies keep a gap from the frame edge pingdotgg/t3code#20281). HTML previews say how their browser exited, by exit code or signal (fix(server): html previews say how their browser exited pingdotgg/t3code#16872).
• Mobile: upstream's React Compiler adoption. Metro compiles every mobile file, reactCompilerCoverage.test.ts ratchets KNOWN_BAILOUTS, and lecturn/no-manual-memo plus the hookless-use rule apply to apps/mobile. Fork-only mobile files follow the same conversions. Also PR sheet link/unlink/watch and badges, Android fold and navigation fixes; the Android rail is gone, the phone bottom bar has Chats/Apps/Pulls, and split view switches lists from the sidebar header.
• Server and packages: provider update and Claude probe recovery fixes, MCP tool usage counting (lecturn_ tools), Lecturn Connect link retries, sectioned orchestration instructions, storage cleanup reaching archived worktrees, pull-request link canonicalization (upstream migration 64, fork id 81).
• Web: about 125 fixes, including the sidebar subagent highlight (also in Apps mode), command palette focus and query retention, keybinding recording, composer fade, narrow-window questions, lighter dark-mode switches, one Browser section in Settings > Integrations with a search engine picker, and hashed notification tags.
• Lecturn main on top: Lecturn Apps (feat(apps): embed Lecturn's chat in other apps #159) and the relay, CI and npm fixes (fix(relay): preserve renewal access and recover managed gateways #155-fix(release): omit bundled workspace packages from npm manifest #158, docs(agents): name the gh command that uploads PR evidence #160) run on the upstream APIs.

Regressions found during verification and fixed here

• Mobile render loop (1d008797): under the React Compiler, any focused screen with an inspector pane (Review with a diff, tablet Files) hit "Maximum update depth exceeded". The same code is in upstream cd8c2c5; this ports upstream's later fix 325a7e2 (fix(mobile): the split-view sidebar no longer crashes in an update loop pingdotgg/t3code#21867) and keeps inspector registration in a ref. Found by the Android capture.
• Sidebar title width (8f8501ab): upstream fix(web): pinned thread marker stays put when hovering the row pingdotgg/t3code#11122's status slot reserved the hover actions' width at rest, and Lecturn's card rows put the title on that line, so titles lost 42% of their width (121 to 70 px). Titles are back to 121 px; a hovered pinned row keeps its pin in place, as fix(web): pinned thread marker stays put when hovering the row pingdotgg/t3code#11122 intends, at the cost of showing about 14 px of title while hovered.
• Android tablet header (b9336fdf): with the Apps tab, "Lecturn" wrapped onto two lines in the 280 dp sidebar. The wordmark is single-line, and below a 320 dp row "Show apps"/"Show pull requests" move into a "More actions" menu.
• Smaller fixes (d34966da, 8f8501ab): the queue drag gesture is no longer rebuilt every render; OpenCode reports a failed Lecturn MCP add only while MCP is not up yet; release CLI builds stamp the telemetry channel; upstream test fixtures use Lecturn names.
• Greptile findings (d8ec6bc9): migrated pull request links keep the unknown link date, so threads edited after their PR merged still auto-settle; the pnpm update probe checks the pnpm the update runs; an expired mobile Connect account gets the sign-in error instead of reconnecting forever; delegated-task analytics keep a bounded dedupe set. The polling note on one upstream adapter test is left: upstream deletes that test and makes the harness event-driven in the next checkpoint.
• CI on Git 2.56 (d34966da): runners moved to Git 2.56, which rewords "not a git repository"; storage cleanup now accepts both wordings. Main has the same latent failure.

Lecturn decisions (recorded in RESOLUTION_GUIDE.md)

• Upstream migration 64 runs as fork id 81, after Lecturn Apps 79/80; it is idempotent.
• The sidebar working-row drag (fix(web): Working threads can be dragged into chat as references again pingdotgg/t3code#19697) and shared working timer (perf(web): sidebar working timers share one clock pingdotgg/t3code#21195) are not taken while the fork sidebar shape stays.
• Telemetry posts to the fork's PostHog host, not upstream's ingest endpoint.
• Lecturn keeps queue reordering, which upstream later deletes.

Checks

• Local, final tree: typecheck (35 packages), lint, format, knip, mobile native static check (SwiftLint, ktlint, detekt).
• Local suites on the merge: web unit 8,284 and browser 1,319; server 8,370; packages 6,673; mobile 3,928 (run the way CI runs it, after the fixes); desktop 1,700; relay 857; embed 88; embed-host 18.
• CI green on the final head.

Review

• Independent exact-tree reviews of the merge (web, server/packages, mobile, deps/CI/identity): pass with nits; the introduced nits are fixed in d34966da. Fresh reviews of each later commit, including a sweep of both apps for the bug classes the captures exposed (effect events as dependencies, unmemoized providers, upstream row-layout assumptions): pass with nits, none open.
• Greptile: five findings; four fixed in d8ec6bc9, one left with the reason in its thread.
• Grok outside review: accepted the merge and every follow-up commit; its one open note (on pinned rows, Tab reaches the hover actions before the pin) matches the visual order and is left as is.

Follow-ups (on main or upstream already, not changed here)

• Two other Git error matchers (GitVcsDriverCore.ts:510, GitManager.ts:197) only know the pre-2.56 "not a git repository" wording.
• The Stave memory MCP server is not re-added after OpenCode drops idle servers (the analogue of upstream fix(server): OpenCode 2 threads keep T3's tools after an idle project is evicted pingdotgg/t3code#16796).
• In the command palette, an "open-app" request with no apps stays pending; on Android, an app thread's toolbar back arrow goes to Threads, not Apps; Codex receives connected-app instructions in developer_instructions.
• Opening /draft/<id> directly crashes the composer on the dev server, on main too.
• Migration 050 (on main and upstream) gave links imported from the pre-V2 model the thread's last-update time as their link time, so a few of them can miss auto-settle the same way.

Evidence heads

The final head is d8ec6bc9; its last commit changes only server, provider-core and client-runtime code, none of it in a captured scene. Web images were captured on 8f8501ab; nothing under apps/web, apps/server, apps/desktop or packages changed after it. Android images were captured on b9336fdf; 3f7510ad then changed only the header cutoff for larger app fonts in ThreadListToolbar.tsx, with identical default-font output (the showcase's font), covered by unit tests. The MCP App full-screen scene uses a real stub MCP App, not a test double.

UI evidence: isolated synthetic fixture (web dev server, stub Codex, headless Chrome 1440x900 @1x dark)

Before = Lecturn main 12c3dc3; after = PR head 8f8501a (upstream checkpoint cd8c2c5 merged with main, plus review fixes). Every after image was captured on 8f8501a.

No regressions. The sidebar title-width regression found on 18f0d00 (pingdotgg#11122 status slot: 83 px slot, 70 px titles) is fixed on 8f8501a (rows 18 and 18h). Every other difference is an expected upstream change.

Scene	Before (main 12c3dc3)	After (8f8501a)	Verdict
Home: new-thread composer and sidebar Penguin Lab draft, opened from the sidebar (a direct load of /draft/<id> crashes on both sides, see notes).			same (pixel-identical)
Thread timeline and composer User message, expanded work log (reasoning, commentary, command row, file-change row), markdown answer.			same (only the turn clock and sidebar relative times differ)
Right panel: Diff README.md expanded (an uncommitted edit in the fixture repo).			same (only sidebar relative times differ)
Command palette Cmd+K over the thread.			same (pixel-identical)
Settings > Connections Local environment card and Environments.			expected difference: the off Network access switch has a lighter thumb in dark mode (t3code#14984). The port in the Version row also differs.
Settings > Providers Stub Codex selected, Claude disabled.			expected difference: the off Claude switch has a lighter thumb in dark mode (t3code#14984). "Checked … ago" also differs.
Usage: Cost 30 days over synthetic Codex rollouts.			same (only sidebar relative times differ)
Usage: Tokens Same data, Tokens view.			same (only sidebar relative times differ)
Right panel: Linked pull requests #12-#14 linked by URL (GitHub disabled, rows unsynced).			same (only sidebar relative times differ)
Pull requests page GitHub disabled in the fixture, so it shows the could-not-load state.			same (only sidebar relative times differ)
Mobile thread (390x844) Same thread at mobile width.			same (0.001% of pixels)
Visual reply in full screen (pingdotgg#20281) An html_render reply opened with Open full screen. The page has a full-bleed background.			expected difference (t3code#20281): the page now sits 16 px inside the frame edge (inset 0 px before, 16 px on 8f8501a)
Visual reply full screen: frame corner 560x330 crop of the same state around the frame's top-left corner.			expected difference (t3code#20281): before, the page touches the rounded frame; after, a 16 px ring of background separates them
MCP App that asks for full screen on load (pingdotgg#18548) Synthetic penguin-board MCP App, fresh page load with no tap. The app prints the host's answer.			expected difference (t3code#18548): before, the app takes the whole window on load (Load request: granted); after, it stays inline (Load request: refused)
MCP App: tap Open full screen in the app Exit full screen if open, wait 6.5 s, then click the app's own button.			same outcome: a tap in the app opens full screen on both sides; only the app's Load request pill differs (granted before, refused after)
Apps mode: app thread (#159) Synthetic connected app Colony Tracker. Sidebar in Apps mode, ChatHeader app breadcrumb.			same (pixel-identical): Apps mode and the Colony Tracker icon and name in the ChatHeader breadcrumb on both sides
Apps mode: subagent of the app thread open Scout-north child of the app thread.			expected difference (t3code#15163, fork Apps sidebar): after highlights the parent app-thread row; before has no highlighted row
Projects mode: subagent open (pingdotgg#15163) Scout-north child of a Penguin Lab thread.			expected difference (t3code#15163): after highlights the parent row; before has no highlighted row
Settings > Integrations: Browser (pingdotgg#18264) Top of the page.			expected difference (t3code#18264): one Browser section instead of two
Settings > Integrations: links and search (pingdotgg#17688) Scrolled to Search engine (after) or Open links in (before).			expected difference (t3code#17688): a new Search engine picker (DuckDuckGo)
Command palette: Back keeps the search (pingdotgg#15940) Typed "new thr", chose New thread in..., then Backspace back.			expected difference (t3code#15940): after keeps "new thr" in the search field after Back; before clears it
Draft hero with a long project name (pingdotgg#18858) New thread in the Antarctic Field Station ... project.			expected difference (t3code#18858): the long name is truncated in the middle on its own line, with ? kept beside it; before cut it at the end ("Antarctic Field St… ?")
Thread without a project Cmd+K New thread without a project, one stub turn. Header breadcrumb.			same (No project header on both sides; only relative times and "Worked for" differ)
Sidebar thread rows (crop) 260x600 crop of the sidebar from a second run with the same steps as scene 1. Rows at rest, no hover.			same: rows at rest measure a 32 px status slot and a 121 px title on both sides (on 18f0d00: 83 px and 70 px, fixed in 8f8501a)
Sidebar with a pinned row, at rest (crop) (pingdotgg#11122) "Make remote coding feel local" pinned from its context menu; pointer parked away. 260x600 crop.			same: the pinned row title is 103 px and the pin is at x=177 on both sides
Pinned row hovered (crop) (pingdotgg#11122) Pointer on the pinned row. 260x160 crop.			expected difference (t3code#11122): on hover, the pin and the "8m" stay put and Snooze/Settle open to their left. Before, the pin jumped 177 to 126 px and the status was hidden. Trade-off: the hovered title shows about 14 px ("M.") instead of 52 px.
Plain row hovered (crop) Pointer on "Put the command center in your pocket". 260x160 crop.			same: Snooze/Settle replace the status at the right end on both sides (title 70 px)

The same scripted steps ran on both sides (replay.sh). Each side used an isolated synthetic fixture home seeded by Lecturn main, with a stub Codex, Claude off and HOME pointed at the fixture. The github.com host was disabled and the host label is masked to "Fixture Mac". New fixture pieces for this checkpoint:

• a synthetic MCP App served by the stub Codex. It asks for full screen right after it loads and prints the host's answer;
• a granted synthetic connected app, Colony Tracker, with no tools;
• an html_render page with a full-bleed background.

Every after image was captured on 8f8501a; nothing is reused from 18f0d00. Scenes 1, 18 and 18h come from a second run of each side with the same short step list. A pixel diff (channel delta >40) backs every "same" verdict: what remains is relative times, the turn clock and the server port.

Fixed since 18f0d00: on 18f0d00 every sidebar row reserved the width of its hover actions at rest (t3code#11122), so titles shrank from 121 to 70 px. 8f8501a measures 121 px again.

Pinned rows: on hover, the pin and status now stay in place, as pingdotgg#11122 intends. The trade-off is that a hovered pinned row shows only about 14 px of title (row 18h).

Pre-existing, on both sides: loading or reloading /draft/<id> directly (where / redirects) crashes the composer on the dev server with "[tiptap error]: The editor view is not available". Scene 1 therefore opens the draft from the sidebar.

Not shown:

• fix(web): composer host and workspace tooltips show their shortcuts pingdotgg/t3code#21167 (shortcut in the workspace tooltip): at this width the fork's draft composer renders its own compact workspace control, so the upstream tooltip trigger is not mounted.
• fix(web): pending questions no longer squash the composer on narrow windows pingdotgg/t3code#20391, fix(web): a workflow thread opens with its phases and agents instead of its script pingdotgg/t3code#20857, fix(web): show a real arrow in the context compacted divider pingdotgg/t3code#20326, fix(web,mobile): queued messages no longer say "From queue" once sent pingdotgg/t3code#21474, fix(web): stop repeating the subagent name in the waiting banner pingdotgg/t3code#16022, fix(web): stop composer banner glass overlap pingdotgg/t3code#8034, fix(web): standalone auth pages scroll when the card is taller than the window pingdotgg/t3code#19603, fix(desktop): explain why the update button is disabled pingdotgg/t3code#18404, fix(web): collapsed projects no longer leave a border stub in the legacy sidebar pingdotgg/t3code#18314, fix(web): record the layout character in the keybinding editor pingdotgg/t3code#15972/fix(web): preserve unsaved keybinding edits when saving another binding pingdotgg/t3code#11109, fix(web): show pull request checkout error detail pingdotgg/t3code#15007, fix(web): open Azure DevOps PR links in the panel pingdotgg/t3code#10987: not set up in this fixture.

Android showcase (phone and 10-inch tablet, dark, Lecturn theme; GitHub-hosted ubuntu-24.04 capture-only harness)

Before = Lecturn main 12c3dc3 (run 40772717467). After = this PR at b9336fd (run 40786928438). Both runs are green, with 12/12 scenes per side. Synthetic showcase fixture only.

Phone (1080×1920)

Scene	Before (12c3dc3)	After (b9336fd)	Notes
Threads list			PASS: 0.06% changed, only glass-card edge anti-aliasing on one row. The bottom bar with Chats / Apps / Pulls is pixel-identical; the Lecturn crest, gold Decisions and New thread FAB are kept
Thread			PASS: the message feed renders (both bubbles). Only the fixture timestamps differ (0.13%)
Terminal			PASS: 0 changed pixels
Review (diff)			PASS: it renders with no render loop. 0.13% changed, all in the bottom gesture-bar row
Environments			Expected difference: the switches sit further left because the chevron is now its own touch target (upstream pingdotgg#17677). The environment order and routing ports vary between fixture runs
Agent activity			PASS: 0 changed pixels

10-inch tablet, split view (1440×2560, about 800 dp)

Scene	Before (12c3dc3)	After (b9336fd)	Notes
Threads			Expected difference (upstream pingdotgg#21071 plus the #159 Apps port): the Chats/Apps/PRs navigation rail is gone. The sidebar header shows "Lecturn" on one line with Search, Settings and More actions; Show apps and Show pull requests sit in the More menu, because the 280 dp sidebar is under the inline-button width
Thread			Expected difference: the rail is gone and the content is wider. The feed renders. The header matches the Threads scene
Terminal			Expected difference: the rail is gone. The header matches the Threads scene
Review (diff)			Expected difference: the rail is gone. It renders with no render loop
Environments			Expected difference: the rail is gone, and the switch and chevron changes from pingdotgg#17677 apply
Agent activity			PASS: 0 changed pixels

Sidebar header crop, top to bottom: main 12c3dc3 (rail layout), the intermediate 1d00879 (wordmark wrapped, fixed since), and this PR's b9336fd:

🤖 Generated with Claude Code

[greptile-apps]

Reply tests depend on polling

The new reply check calls awaitUntil, which polls for at most 5,000 scheduler yields. AGENTS.md requires backend tests to await a specific event or Deferred and forbids polling. Slow file I/O can outlast those yields.

Signal a Deferred when the collector receives the expected reply and await it instead. Other new adapter tests also use this helper. This repository requirement must be satisfied before merging.

Context Used: AGENTS.md (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

[Nurozen]

Confirmed: this breaks the AGENTS.md no-polling rule. We're not changing it in this PR. The awaitUntil helper is already used 178 times in this file on main, and this test came from upstream pingdotgg#21310. Upstream later deleted the test (pingdotgg#22557) and made the adapter harnesses event-driven with a polling lint rule (pingdotgg#22565). Those changes arrive with the next upstream checkpoint, and fixing this one call site would mean adding an event hook to the shared harness.

[greptile-apps]

That context makes sense. awaitUntil still violates the no-polling rule in this test, but replacing this one call would require an event hook in the shared harness, and the upcoming checkpoint removes the test while making the harness event-driven. I agree this is better handled there rather than expanding this PR’s scope. I’m withdrawing the “must be fixed before merge” framing; this remains a known follow-up, not a blocker for this PR.