Adds bathymetry downscaling by averaging#354
Open
jagoosw wants to merge 2 commits into
Open
Conversation
Collaborator
Author
|
This PR is a breaking change because it removes the argument |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies
regrid_bathymetryto take an argumentmethod(instead ofinterpolaiton_passes) which isInterpolate(1)by default, and addsMedianAveragingwhich takes the average of the dataset depths within each (coarser) target cell.This is with 20 interpolation passes:

The new method is almost smoother in the spiky bits and sharper on ridges.
I believe this is how they make the ORCA bathymetries: https://www.drakkar-ocean.eu/publications/reports/orca025-g70.pdf and this SCOR report claims median is better but still flawed for coarse models: https://scor-int.org/WG107Report.pdf
I haven't checked it works on GPU yet but hopefully.