Skip to content

Fix bugs in SoilGrids metadata #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
bgroenks96 wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix bugs in SoilGrids metadata #345

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa56cab
Fix incorrect longitude interfaces
bgroenks96 Jun 11, 2026
1df82fb
Add missing cfvo variable
bgroenks96 Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/DataWrangling/SoilGrids/SoilGrids.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ SoilGrids2_dataset_variable_names = Dict(
:sand_fraction => "sand",
:silt_fraction => "silt",
:clay_fraction => "clay",
:coarse_fraction => "cfvo",
:bulk_density => "bdod",
:organic_carbon_density => "ocd",
:soil_organic_carbon => "soc"
Expand All @@ -59,7 +60,7 @@ DataWrangling.available_variables(::SoilGrids2) = SoilGrids2_dataset_variable_na
DataWrangling.default_download_directory(::SoilGrids2) = download_SoilGrids2_cache
DataWrangling.reversed_vertical_axis(::SoilGrids2) = true
DataWrangling.reversed_latitude_axis(::SoilGrids2) = true
DataWrangling.longitude_interfaces(::SoilGrids2) = (-180, 180)
DataWrangling.longitude_interfaces(::SoilGrids2) = (0, 360)
DataWrangling.latitude_interfaces(::SoilGrids2) = (-90, 90)
DataWrangling.z_interfaces(::SoilGrids2) = [-200, -100, -60, -30, -15, -5, 0]
DataWrangling.metadata_filename(::SoilGrids2, name, date, region) = "SoilGrids2_clenshaw_10km_full.nc"
Expand All @@ -75,7 +76,8 @@ DataWrangling.missing_value(md::SoilGrids2Metadatum) = -32768

# Unit conversions
function DataWrangling.conversion_units(metadatum::SoilGrids2Metadatum)
if metadatum.name ∈ (:sand_fraction, :silt_fraction, :clay_fraction)
if metadatum.name ∈ (:sand_fraction, :silt_fraction, :clay_fraction, :coarse_fraction)
# Note that coarse_fraction is technically in cm³/dm³, but the conversion factor is the same, so we ignore that here
return GramPerKilogram()
elseif metadatum.name == :bulk_density
return CentigramPerCubicCentimeter()
Expand Down
Loading