Add GLODAP DataWrangling module#302
Conversation
There was a problem hiding this comment.
You need to add this file in the src/DataWrangling/DataWrangling.jl, otherwise NumericalEarth is oblivious to it.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Co-authored-by: Navid C. Constantinou <navidcy@users.noreply.github.com>
Co-authored-by: Navid C. Constantinou <navidcy@users.noreply.github.com>
Co-authored-by: Navid C. Constantinou <navidcy@users.noreply.github.com>
Co-authored-by: Navid C. Constantinou <navidcy@users.noreply.github.com>
Co-authored-by: Navid C. Constantinou <navidcy@users.noreply.github.com>
Co-authored-by: Navid C. Constantinou <navidcy@users.noreply.github.com>
Co-authored-by: Navid C. Constantinou <navidcy@users.noreply.github.com>
Co-authored-by: Navid C. Constantinou <navidcy@users.noreply.github.com>
Co-authored-by: Navid C. Constantinou <navidcy@users.noreply.github.com>
Co-authored-by: Navid C. Constantinou <navidcy@users.noreply.github.com>
Co-authored-by: Navid C. Constantinou <navidcy@users.noreply.github.com>
Co-authored-by: Navid C. Constantinou <navidcy@users.noreply.github.com>
Co-authored-by: Navid C. Constantinou <navidcy@users.noreply.github.com>
Co-authored-by: Navid C. Constantinou <navidcy@users.noreply.github.com>
| ) | ||
|
|
||
| # Dataset types | ||
| abstract type GLODAPDataset end |
There was a problem hiding this comment.
| abstract type GLODAPDataset end | |
| abstract type GLODAPDataset <:AbstractStaticDataset end |
from what I understand this product does not have multiple dates right?
| # Custom retrieve_data: GLODAP NetCDF files contain Missing values (from _FillValue) | ||
| # which must be converted to NaN before the GPU kernel in set_metadata_field!. |
There was a problem hiding this comment.
I think this is already handled in the data mangling of retrieve_data right?
There was a problem hiding this comment.
Indeed, here
NumericalEarth.jl/src/DataWrangling/set_region_data.jl
Lines 155 to 159 in 8e6c4c6
I think this whole retrieve_data method can be removed
|
Looks good! I have left some comments. Can you also add one unit test for the metadata creation / handling? (We can probably avoid download tests for now) |
Co-authored-by: Simone Silvestri <silvestri.simone0@gmail.com>
Co-authored-by: Simone Silvestri <silvestri.simone0@gmail.com>
Co-authored-by: Simone Silvestri <silvestri.simone0@gmail.com>
|
Looks like everything has been addressed! @lgloege if you can resolve the conflicts then add a unit test (just test the metadata creation, not the download) we can then merge |
This PR adds the GLODAP gridded climatology to NumericalEarth for initializing BGC fields. GLODAP does not require any authentication and the data is distributed under CC BY 4.0 license.
@simone-silvestri