Fix clippy::double_parens lint in throw!#15
Open
sendittothenewts wants to merge 1 commit intoNullus157:mainfrom
Open
Fix clippy::double_parens lint in throw!#15sendittothenewts wants to merge 1 commit intoNullus157:mainfrom
clippy::double_parens lint in throw!#15sendittothenewts wants to merge 1 commit intoNullus157:mainfrom
Conversation
As of Rust nightly 2025-10-08, every use of the `throw!` macros now emits this warn-by-default lint. The warning is seen by downstream users of culpa, but not when linting culpa itself, unless you pass the `--all-targets` flag to `cargo clippy` to lint the tests. rust-lang/rust-clippy#15852 (comment) suggests that this new behaviour is by design. This simply removes the redundant brackets introduced by a5b67d1.
Author
|
The relevant change in clippy's behaviour has now landed in Rust 1.92.0-beta.1, so this is becoming important. |
Author
|
FWIW, there is a fix for this in nightly clippy now, but it hasn't been backported to 1.92.0-beta.4, so it looks like this will affect the next stable release. |
Author
|
Happily, the fix for this did make it into Rust 1.92 stable. So, while maybe still a reasonable cleanup, this PR is not important after all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of Rust nightly 2025-10-08, every use of the
throw!macros now emits this warn-by-default lint.The warning is seen by downstream users of culpa, but not when linting culpa itself, unless you pass the
--all-targetsflag tocargo clippyto lint the tests.rust-lang/rust-clippy#15852 (comment) suggests that this new behaviour is by design.
This simply removes the redundant brackets introduced by a5b67d1.