Improve type-security with phpstan and set up phpunit#1004
Open
alsciende wants to merge 11 commits intoNull-Signal-Games:mainfrom
Open
Improve type-security with phpstan and set up phpunit#1004alsciende wants to merge 11 commits intoNull-Signal-Games:mainfrom
alsciende wants to merge 11 commits intoNull-Signal-Games:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal is to prepare an upgrade of Symfony from the 3.x version to an up-to-date 8.x version. For this, we need a better test suite to prevent regression. So phpstan and phpunit need to strongly constraint future code evolutions.
What this PR changes in the code:
What this PR brings to the table:
To run the tests, execute this from your nrdb-dev-env directory: