feat: update loading widget with twin animation#18
Merged
Conversation
Collaborator
Author
|
The loading widget has been updated. I have implemented two versions: one using the SpinKit package and another using Tween animations. Please let me know which one is preferred for use in the app. |
| @override | ||
| void initState() { | ||
| super.initState(); | ||
| _c = AnimationController(vsync: this, duration: widget.speed)..repeat(); |
Collaborator
There was a problem hiding this comment.
The naming should be improved instead of _c use somthing like _animationController
| this.spacingFactor = 0.10, | ||
| this.minHeightFactor = 0.12, | ||
| this.speed = const Duration(milliseconds: 1200), | ||
| }); |
Collaborator
There was a problem hiding this comment.
At this time, I think the speed should be faster
TalebRafiepour
left a comment
TalebRafiepour
left a comment
Collaborator
There was a problem hiding this comment.
Good work overall. Only a small modification is needed, and the use of SpinKit is not required at this time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Closes #
Type of Change
Changes Made
Screenshots/Videos
Click to view screenshots/videos
Testing
Platforms Tested
Test Coverage
Testing Steps
Checklist
flutter analyzeand resolved all issuesdart format .to format my codeapp_en.arbandapp_fa.arb)Breaking Changes
N/A
Additional Context
Commit Message Format
Main commit type:
<type>(<scope>): <subject>Reviewer Notes: