feat(docker): add production-ready Dockerfile and docker-compose setup#82
Open
germanfica wants to merge 2 commits intoNotWoods:mainfrom
Open
feat(docker): add production-ready Dockerfile and docker-compose setup#82germanfica wants to merge 2 commits intoNotWoods:mainfrom
germanfica wants to merge 2 commits intoNotWoods:mainfrom
Conversation
- Add multi-stage Dockerfile: - Build stage with Node.js 20 (slim image) - Runtime stage using Nginx (alpine image) - Add docker-compose.yml for local orchestration: - Build service from Dockerfile - Expose container on port 5173 mapped to port 80 - Set NODE_ENV to production
- Update docker-compose.yml: - Change port mapping from 5173:80 to 8080:80 - Use 8080 as a more conventional host port for production web servers - Avoid confusion with Vite's default dev port (5173)
Author
|
Hi! I opened this PR to add a production-ready Docker setup. Hope it's useful, and happy to adjust anything if needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a production-ready Docker setup: