Add step to set BACKSTAGE_UPLOAD_SECRET in GitHub Actions workflow#152
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the test GitHub Actions workflow to provide a fallback BACKSTAGE_UPLOAD_SECRET, preventing build-time failures when the secret is unavailable in PR contexts.
Changes:
- Adds a workflow step that writes
BACKSTAGE_UPLOAD_SECRETto$GITHUB_ENV. - Uses
dummy-secret-in-PRwhen the secret is missing or empty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does?
This pull request makes a small update to the GitHub Actions workflow. It ensures that the
BACKSTAGE_UPLOAD_SECRETenvironment variable is always set during the test job, defaulting to a dummy value if not already provided. This helps prevent errors related to missing secrets in pull requests.BACKSTAGE_UPLOAD_SECRETto a default value (dummy-secret-in-PR) if it is not already defined in the environment, improving workflow reliability for PRs.Summary made by Copilot.
Prerequisites
package.json's version per semver?