Sync with upstream

.github/DISCUSSION_TEMPLATE/bug-reports.yml

@@ -73,7 +73,7 @@ body:
       label: Version
       description: Which version of the game did the bug happen in? You can see the current version number in the bottom left corner of your screen in the main menu.
       options:
-        - v1.12.6.2 (Spring Update 2026)
+        - v1.13.3.1 (Summer Update 2026)
         - Other
     validations:
       required: true

Barotrauma/BarotraumaClient/ClientSource/Characters/Health/CharacterHealth.cs

@@ -258,14 +258,20 @@ partial void InitProjSpecific(ContentXElement element, Character character)
                 //RelativeSpacing = 0.05f
             };
 
-            InventorySlotContainer = new GUICustomComponent(new RectTransform(new Vector2(0.1f, 1.0f), characterIndicatorArea.RectTransform, Anchor.TopLeft, Pivot.TopRight),
+            GUIFrame left = new(new RectTransform(new Vector2(0.25f, 1f), characterIndicatorArea.RectTransform), style: null);
+
+            InventorySlotContainer = new GUICustomComponent(new RectTransform(Vector2.One, left.RectTransform),
                 (spriteBatch, component) =>
                 {
                     for (int i = 0; i < character.Inventory.Capacity; i++)
                     {
                         if (character.Inventory.SlotTypes[i] != InvSlotType.HealthInterface) { continue; }
                         if (character.Inventory.HideSlot(i)) { continue; }
 
+                        int width = Character.Inventory.visualSlots[i].Rect.Width;
+                        left.RectTransform.MinSize = new Point(width, left.RectTransform.MinSize.Y);
+                        if (afflictionIconList != null) { afflictionIconList.RectTransform.MinSize = new Point(width, afflictionIconList.RectTransform.MinSize.Y); }
+
                         //don't draw the item if it's being dragged out of the slot
                         bool drawItem = !Inventory.DraggingItems.Any() || !Character.Inventory.GetItemsAt(i).All(it => Inventory.DraggingItems.Contains(it)) || character.Inventory.visualSlots[i].MouseOn();
 
@@ -292,8 +298,7 @@ partial void InitProjSpecific(ContentXElement element, Character character)
                     }
                 });
 
-
-            cprButton = new GUIButton(new RectTransform(new Vector2(0.17f, 0.17f), characterIndicatorArea.RectTransform, Anchor.BottomLeft, scaleBasis: ScaleBasis.Smallest), text: "", style: "CPRButton")
+            cprButton = new GUIButton(new RectTransform(new Vector2(0.75f), left.RectTransform, Anchor.BottomLeft, scaleBasis: ScaleBasis.Smallest), text: "", style: "CPRButton")
             {
                 UserData = UIHighlightAction.ElementId.CPRButton,
                 OnClicked = (button, userData) =>
@@ -316,12 +321,11 @@ partial void InitProjSpecific(ContentXElement element, Character character)
 
                     return true;
                 },
-                ToolTip = TextManager.Get("doctor.cprobjective"),
-                IgnoreLayoutGroups = true,
+                ToolTip = TextManager.Get("tutorial.roles.medic.objective.cpr"),
                 Visible = false
             };
 
-            var limbSelection = new GUICustomComponent(new RectTransform(new Vector2(0.4f, 1.0f), characterIndicatorArea.RectTransform),
+            var limbSelection = new GUICustomComponent(new RectTransform(new Vector2(0.5f, 1.0f), characterIndicatorArea.RectTransform),
                 (spriteBatch, component) =>
                 {
                     DrawHealthWindow(spriteBatch, component.RectTransform.Rect, true);
@@ -368,8 +372,6 @@ partial void InitProjSpecific(ContentXElement element, Character character)
                 CanBeFocused = false
             };
 
-            characterIndicatorArea.Recalculate();
-
             healthBarHolder = new GUIFrame(new RectTransform(Point.Zero, GUI.Canvas), style: null)
             {
                 HoverCursor = CursorState.Hand

Barotrauma/BarotraumaClient/ClientSource/DebugConsole.cs

@@ -866,7 +866,20 @@ async Task gameOwnershipTokenTest()
                         GameSettings.SaveCurrentConfig();
                     });
             }, isCheat: false));
-
+
+            commands.Add(new Command("togglespoofeventmanagerid", "togglespoofeventmanagerid: Forces the client to report the last received event ID as always being 1, making the server believe the client is always behind.", (string[] args) =>
+            {
+                if (GameMain.Client != null)
+                {
+                    GameMain.Client.SpoofEntityManagerReceivedId = !GameMain.Client.SpoofEntityManagerReceivedId;
+                    DebugConsole.NewMessage(GameMain.Client.SpoofEntityManagerReceivedId ? "Spoofing enabled ": "Spoofing disabled", Color.Green);
+                }
+                else
+                {
+                    DebugConsole.NewMessage("Not connected to server", Color.Red);
+                }
+            }));
+
             commands.Add(new Command("togglegrid", "Toggle visual snap grid in sub editor.", (string[] args) =>
             {
                 SubEditorScreen.ShouldDrawGrid = !SubEditorScreen.ShouldDrawGrid;
@@ -4454,17 +4467,24 @@ private static void GetAdjustedPrice(ItemPrefab itemPrefab, ref int componentCos
 
         public static void StartLocalMPSession(int numClients = 2)
         {
+            string extraArguments = "-multiclienttestmode";
+            if (NetConfig.UseLenientHandshake)
+            {
+                extraArguments += " -lenienthandshake";
+            }
+
             try
             {
                 if (Process.GetProcessesByName("DedicatedServer").Length == 0)
                 {
 #if WINDOWS
-                    Process.Start("DedicatedServer.exe", arguments: "-multiclienttestmode");
+                    Process.Start("DedicatedServer.exe", arguments: extraArguments);
 #else
-                    Process.Start("./DedicatedServer", arguments: "-multiclienttestmode");
+                    Process.Start("./DedicatedServer", arguments: extraArguments);
 #endif
                     System.Threading.Thread.Sleep(1000);
                 }
+
 #if DEBUG
                 GameClient.MultiClientTestMode = true;
 #endif
@@ -4478,10 +4498,13 @@ public static void StartLocalMPSession(int numClients = 2)
                     for (int i = 2; i <= numClients; i++)
                     {
                         System.Threading.Thread.Sleep(1000);
+
+                        string clientArguments = $"-connect server localhost -username client{i} -skipintro";
+
 #if WINDOWS
-                        Process.Start("Barotrauma.exe", arguments: "-connect server localhost -username client" + i + " -multiclienttestmode");
+                        Process.Start("Barotrauma.exe", arguments: $"{clientArguments} {extraArguments}");
 #else
-                        Process.Start("./Barotrauma", arguments: "-connect server localhost -username client" + i + " -multiclienttestmode");
+                        Process.Start("./Barotrauma", arguments: $"{clientArguments} {extraArguments}");
 #endif
                     }
                 }

Barotrauma/BarotraumaClient/ClientSource/GUI/GUI.cs

@@ -14,6 +14,7 @@
 using Microsoft.Xna.Framework.Graphics;
 using Microsoft.Xna.Framework.Input;
 using System.Collections.Immutable;
+using System.Diagnostics.CodeAnalysis;
 
 namespace Barotrauma
 {
@@ -649,12 +650,12 @@ public static void Draw(Camera cam, SpriteBatch spriteBatch)
                 DrawMessages(spriteBatch, cam);
 
                 if (MouseOn != null)
-                { 
+                {
+                    MouseOn.OnDrawToolTip?.Invoke(MouseOn);
                     if (!MouseOn.ToolTip.IsNullOrWhiteSpace())
                     {
                         MouseOn.DrawToolTip(spriteBatch);
                     }
-                    MouseOn.OnDrawToolTip?.Invoke(MouseOn);
                 }
 
                 if (SubEditorScreen.IsSubEditor())
@@ -2323,10 +2324,10 @@ public static GUIMessageBox PromptTextInput(LocalizedString header, string body,
         /// <summary>
         /// Creates a 7-segment display.
         /// </summary>
-        /// <param name="leftLabel">Returns <see langword="null"/> if <paramref name="leftLabelText"/> is <see langword="null"/> or empty.</param>
+        /// <param name="leftLabel">Returns <see langword="null"/> if <paramref name="leftLabelText"/> is <see langword="null"/>.</param>
         /// <param name="rightLabelText">Defaults to <c>TextManager.Get("kilowatt")</c>.</param>
         /// <param name="leftLabelFont">Defaults to <see cref="GUIStyle.LargeFont"/>.</param>
-        public static GUITextBlock CreateDigitalDisplay(RectTransform rect, out GUITextBlock? leftLabel, out GUITextBlock rightLabel, LocalizedString? leftLabelText = null, LocalizedString? rightLabelText = null, LocalizedString? tooltip = null, GUIFont? leftLabelFont = null)
+        public static GUITextBlock CreateDigitalDisplay(RectTransform rect, [NotNullIfNotNull(nameof(leftLabelText))] out GUITextBlock? leftLabel, out GUITextBlock rightLabel, LocalizedString? leftLabelText = null, LocalizedString? rightLabelText = null, LocalizedString? tooltip = null, GUIFont? leftLabelFont = null)
         {
             GUILayoutGroup textArea = new(rect, isHorizontal: true, childAnchor: Anchor.CenterLeft)
             {
@@ -2337,7 +2338,7 @@ public static GUITextBlock CreateDigitalDisplay(RectTransform rect, out GUITextB
             };
 
             leftLabel = null;
-            if (!leftLabelText.IsNullOrEmpty())
+            if (leftLabelText != null)
             {
                 leftLabel = new GUITextBlock(new RectTransform(new Vector2(0.4f, 1f), textArea.RectTransform), leftLabelText, textColor: GUIStyle.TextColorBright, font: leftLabelFont ?? GUIStyle.LargeFont, textAlignment: Alignment.CenterRight);
             }

Barotrauma/BarotraumaClient/ClientSource/GUI/GUITextBox.cs

@@ -384,14 +384,14 @@ public void Select(int forcedCaretIndex = -1, bool ignoreSelectSound = false)
             CaretIndex = forcedCaretIndex == - 1 ? textBlock.GetCaretIndexFromScreenPos(PlayerInput.MousePosition) : forcedCaretIndex;
             CalculateCaretPos();
             ClearSelection();
-            bool wasSelected = selected;
-            selected = true;
-            GUI.KeyboardDispatcher.Subscriber = this;
             OnSelected?.Invoke(this, Keys.None);
-            if (!wasSelected && PlaySoundOnSelect && !ignoreSelectSound)
+            if (!selected && PlaySoundOnSelect && !ignoreSelectSound)
             {
                 SoundPlayer.PlayUISound(GUISoundType.Select);
             }
+            selected = true;
+            //set this after we've set selected to true -> otherwise the textbox taking keyboard focus will trigger Select again
+            GUI.KeyboardDispatcher.Subscriber = this;
         }
 
         public void Deselect()

Barotrauma/BarotraumaClient/ClientSource/GUI/LoadingScreen.cs

@@ -113,7 +113,10 @@ public void Draw(SpriteBatch spriteBatch, GraphicsDevice graphics, float deltaTi
 
             spriteBatch.Begin(SpriteSortMode.Deferred, BlendState.NonPremultiplied, samplerState: GUI.SamplerState);
 
-            GUI.DrawBackgroundSprite(spriteBatch, currentBackgroundTexture, Color.White, drawArea);
+            if (currentBackgroundTexture.Texture != null)
+            {
+                GUI.DrawBackgroundSprite(spriteBatch, currentBackgroundTexture, Color.White, drawArea);
+            }
             overlay.Draw(spriteBatch, Vector2.Zero, scale: overlayScale);
 
             double noiseT = Timing.TotalTime * 0.02f;

Barotrauma/BarotraumaClient/ClientSource/GameMain.cs

@@ -278,6 +278,12 @@ public GameMain(string[] args)
                 GameClient.MultiClientTestMode = true;
             }
 #endif
+
+            if (ConsoleArguments.Contains("-lenienthandshake"))
+            {
+                NetConfig.UseLenientHandshake = true;
+            }
+
             GUI.KeyboardDispatcher = new EventInput.KeyboardDispatcher(Window);
 
             PerformanceCounter = new PerformanceCounter();

Barotrauma/BarotraumaClient/ClientSource/Items/CharacterInventory.cs

@@ -127,12 +127,6 @@ public override void CreateSlots()
                     (int)SlotPositions[i].X, 
                     (int)SlotPositions[i].Y,
                     (int)(slotSprite.size.X * multiplier), (int)(slotSprite.size.Y * multiplier));
-
-                if (SlotTypes[i] == InvSlotType.HealthInterface &&
-                    character.CharacterHealth?.InventorySlotContainer != null)
-                {
-                    slotRect.Width = slotRect.Height = (int)(character.CharacterHealth.InventorySlotContainer.Rect.Width * 1.2f);
-                }
 
                 ItemContainer itemContainer = slots[i].FirstOrDefault()?.GetComponent<ItemContainer>();
                 if (itemContainer != null)
@@ -622,6 +616,7 @@ public override void Update(float deltaTime, Camera cam, bool isSubInventory = f
 
             for (int i = 0; i < capacity; i++)
             {
+                if (HideSlot(i)) { continue; }
                 var item = slots[i].FirstOrDefault();
                 if (item != null)
                 {

Barotrauma/BarotraumaClient/ClientSource/Items/Components/Machines/Controller.cs

@@ -26,7 +26,7 @@ public void UpdateMsg()
             }
             else
             {
-                DisplayMsg = TextManager.ParseInputTypes(TextManager.Get(Msg));
+                DisplayMsg = TextManager.ParseInputTypes(TextManager.Get(Msg)).Fallback(Msg);
             }
 
             CharacterHUD.RecreateHudTextsIfControlling(Character.Controlled);