Sync with upstream

.github/workflows/publish-release.yml

@@ -64,15 +64,19 @@ env:
     Mono.Cecil.Mdb.dll
     Mono.Cecil.Pdb.dll
     Mono.Cecil.Rocks.dll
-    Microsoft.CodeAnalysis.CSharp.Scripting.dll
+    LightInject.dll
+    OneOf.dll
+    FluentResults.dll
+    Basic.Reference.Assemblies.Net80.dll
+    Microsoft.Extensions.Logging.Abstractions.dll
+    Microsoft.Toolkit.Diagnostics.dll
     Microsoft.CodeAnalysis.CSharp.dll
     Microsoft.CodeAnalysis.dll
-    Microsoft.CodeAnalysis.Scripting.dll
     System.Collections.Immutable.dll
     System.Reflection.Metadata.dll
     System.Runtime.CompilerServices.Unsafe.dll
     mscordaccore_amd64_amd64_*
-    Lua
+    LocalMods/LuaCsForBarotrauma
 
 jobs:
   build:

.gitignore

@@ -15,6 +15,7 @@ bld/
 [Rr]eleaseMac/
 [Dd]ebugLinux/
 [Rr]eleaseLinux/
+LocalMods/
 *.o
 */Barotrauma*/doc/
 

Barotrauma/BarotraumaClient/ClientSource/Characters/AI/EnemyAIController.cs

@@ -29,23 +29,24 @@ public override void DebugDraw(SpriteBatch spriteBatch)
                     }
                 }
             }
-            else if (SelectedAiTarget?.Entity != null)
+            else if (SelectedAiTarget?.Entity != null && AttackLimb != null)
             {
                 Vector2 targetPos = SelectedAiTarget.Entity.DrawPosition;
                 if (State == AIState.Attack)
                 {
                     targetPos = attackWorldPos;
                 }
                 targetPos.Y = -targetPos.Y;
-
-                GUI.DrawLine(spriteBatch, pos, targetPos, GUIStyle.Red * 0.5f, 0, 4);
+                Vector2 attackLimbPos = AttackLimb.DrawPosition;
+                attackLimbPos.Y = -attackLimbPos.Y;
+                GUI.DrawLine(spriteBatch, attackLimbPos, targetPos, GUIStyle.Red * 0.75f, 0, 4);
                 if (wallTarget != null && !IsCoolDownRunning)
                 {
                     Vector2 wallTargetPos = wallTarget.Position;
                     if (wallTarget.Structure.Submarine != null) { wallTargetPos += wallTarget.Structure.Submarine.DrawPosition; }
                     wallTargetPos.Y = -wallTargetPos.Y;
                     GUI.DrawRectangle(spriteBatch, wallTargetPos - new Vector2(10.0f, 10.0f), new Vector2(20.0f, 20.0f), Color.Orange, false);
-                    GUI.DrawLine(spriteBatch, pos, wallTargetPos, Color.Orange * 0.5f, 0, 5);
+                    GUI.DrawLine(spriteBatch, attackLimbPos, wallTargetPos, Color.Orange * 0.75f, 0, 5);
                 }
                 GUI.DrawString(spriteBatch, pos - Vector2.UnitY * 60.0f, $"{SelectedAiTarget.Entity}", GUIStyle.Red, Color.Black);
                 GUI.DrawString(spriteBatch, pos - Vector2.UnitY * 40.0f, $"{targetValue.FormatZeroDecimal()} (M: {CurrentTargetMemory?.Priority.FormatZeroDecimal()}, P: {CurrentTargetingParams?.Priority.FormatZeroDecimal()})", GUIStyle.Red, Color.Black);

Barotrauma/BarotraumaClient/ClientSource/Characters/AI/HumanAIController.cs

@@ -23,6 +23,8 @@ public override void DebugDraw(Microsoft.Xna.Framework.Graphics.SpriteBatch spri
                 //GUI.DrawString(spriteBatch, pos + textOffset, $"AI TARGET: {SelectedAiTarget.Entity.ToString()}", Color.White, Color.Black);
             }
 
+            Vector2 spacing = new Vector2(0, GUIStyle.Font.MeasureChar('T').Y);
+
             Vector2 stringDrawPos = pos + textOffset;
             GUI.DrawString(spriteBatch, stringDrawPos, Character.Name, Color.White, Color.Black);
 
@@ -33,14 +35,14 @@ public override void DebugDraw(Microsoft.Xna.Framework.Graphics.SpriteBatch spri
                 currentOrders.Sort((x, y) => y.ManualPriority.CompareTo(x.ManualPriority));
                 for (int i = 0; i < currentOrders.Count; i++)
                 {
-                    stringDrawPos += new Vector2(0, 20);
+                    stringDrawPos += spacing;
                     var order = currentOrders[i];
                     GUI.DrawString(spriteBatch, stringDrawPos, $"ORDER {i + 1}: {order.Objective.DebugTag} ({order.Objective.Priority.FormatZeroDecimal()})", Color.White, Color.Black);
                 }
             }
             else if (ObjectiveManager.WaitTimer > 0)
             {
-                stringDrawPos += new Vector2(0, 20);
+                stringDrawPos += spacing;
                 GUI.DrawString(spriteBatch, stringDrawPos - textOffset, $"Waiting... {ObjectiveManager.WaitTimer.FormatZeroDecimal()}", Color.White, Color.Black);
             }
             var currentObjective = ObjectiveManager.CurrentObjective;
@@ -49,19 +51,19 @@ public override void DebugDraw(Microsoft.Xna.Framework.Graphics.SpriteBatch spri
                 int offset = currentOrder != null ? 20 + ((ObjectiveManager.CurrentOrders.Count - 1) * 20) : 0;
                 if (currentOrder == null || currentOrder.Priority <= 0)
                 {
-                    stringDrawPos += new Vector2(0, 20);
+                    stringDrawPos += spacing;
                     GUI.DrawString(spriteBatch, stringDrawPos, $"MAIN OBJECTIVE: {currentObjective.DebugTag} ({currentObjective.Priority.FormatZeroDecimal()})", Color.White, Color.Black);
                 }
                 var subObjective = currentObjective.CurrentSubObjective;
                 if (subObjective != null)
                 {
-                    stringDrawPos += new Vector2(0, 20);
+                    stringDrawPos += spacing;
                     GUI.DrawString(spriteBatch, stringDrawPos, $"SUBOBJECTIVE: {subObjective.DebugTag} ({subObjective.Priority.FormatZeroDecimal()})", Color.White, Color.Black);
                 }
                 var activeObjective = ObjectiveManager.GetActiveObjective();
                 if (activeObjective != null)
                 {
-                    stringDrawPos += new Vector2(0, 20);
+                    stringDrawPos += spacing;
                     GUI.DrawString(spriteBatch, stringDrawPos, $"ACTIVE OBJECTIVE: {activeObjective.DebugTag} ({activeObjective.Priority.FormatZeroDecimal()})", Color.White, Color.Black);
                 }
                 if (currentObjective is AIObjectiveCombat 
@@ -85,12 +87,12 @@ public override void DebugDraw(Microsoft.Xna.Framework.Graphics.SpriteBatch spri
                 }
             }
 
-            Vector2 objectiveStringDrawPos = stringDrawPos + new Vector2(120, 40);
+            Vector2 objectiveStringDrawPos = stringDrawPos + new Vector2(120, spacing.Y * 2);
             for (int i = 0; i < ObjectiveManager.Objectives.Count; i++)
             {
                 var objective = ObjectiveManager.Objectives[i];
                 GUI.DrawString(spriteBatch, objectiveStringDrawPos, $"{objective.DebugTag} ({objective.Priority.FormatZeroDecimal()})", Color.White, Color.Black * 0.5f);
-                objectiveStringDrawPos += new Vector2(0, 18);
+                objectiveStringDrawPos += spacing * 0.8f;
             }
 
             if (steeringManager is IndoorsSteeringManager pathSteering)

Barotrauma/BarotraumaClient/ClientSource/Characters/Animation/Ragdoll.cs

@@ -547,7 +547,7 @@ partial void SeverLimbJointProjSpecific(LimbJoint limbJoint, bool playSound)
             }
         }
 
-        public void Draw(SpriteBatch spriteBatch, Camera cam)
+        public void Draw(SpriteBatch spriteBatch, Camera cam, bool onlyDrawSeveredLimbs)
         {
             if (simplePhysicsEnabled) { return; }
 
@@ -573,8 +573,12 @@ public void Draw(SpriteBatch spriteBatch, Camera cam)
             {
                 foreach (Limb limb in limbs) { limb.ActiveSprite.Depth += depthOffset; }
             }
-            for (int i = 0; i < limbs.Length; i++)
+            for (int i = 0; i < inversedLimbDrawOrder.Length; i++)
             {
+                if (onlyDrawSeveredLimbs && !inversedLimbDrawOrder[i].IsSevered) 
+                {
+                    continue; 
+                }
                 inversedLimbDrawOrder[i].Draw(spriteBatch, cam, color);
             }
             if (!MathUtils.NearlyEqual(depthOffset, 0.0f))

Barotrauma/BarotraumaClient/ClientSource/Characters/Character.cs

@@ -938,8 +938,8 @@ public void DoVisibilityCheck(Camera cam)
 
         public void Draw(SpriteBatch spriteBatch, Camera cam)
         {
-            if (!Enabled || InvisibleTimer > 0.0f) { return; }
-            AnimController.Draw(spriteBatch, cam);
+            if (!Enabled) { return; }
+            AnimController.Draw(spriteBatch, cam, onlyDrawSeveredLimbs: InvisibleTimer > 0.0f);
         }
 
         public void DrawHUD(SpriteBatch spriteBatch, Camera cam, bool drawHealth = true)

Barotrauma/BarotraumaClient/ClientSource/Characters/InteractionLabelManager.cs

@@ -4,6 +4,7 @@
 using Microsoft.Xna.Framework.Graphics;
 using System.Collections.Generic;
 using Barotrauma.Items.Components;
+using System.Linq;
 
 namespace Barotrauma;
 
@@ -106,12 +107,17 @@ private static void RecalculateLabelPositions(Camera cam, Character character)
             }
 
             RectangleF textRect = GetLabelRect(interactableInRange, cam);
-
-            if (labels.None(l => l.Item == interactableInRange))
+            var existingLabel = labels.FirstOrDefault(l => l.Item == interactableInRange);
+            if (existingLabel == null)
             {
                 var labelData = new LabelData(interactableInRange, textRect, RichString.Rich(interactableInRange.Prefab.Name), cam);
                 labels.Add(labelData);
             }
+            //size of the label doesn't match - can happen when we're using a CJK font which we asynchronously render new symbols for
+            else if (existingLabel.TextRect.Size != textRect.Size)
+            {
+                existingLabel.TextRect = textRect;
+            }
         }
 
         PreventInteractionLabelOverlap(centerPos: character.Position);
@@ -127,7 +133,11 @@ private static bool IsLooseItem(Item item)
     private static RectangleF GetLabelRect(Item item, Camera cam)
     {
         // create rectangle for overlap prevention
-        Vector2 itemTextSizeScreen = GUIStyle.SubHeadingFont.MeasureString(RichString.Rich(item.Prefab.Name).SanitizedValue) * LabelScale;
+
+        string nameText = RichString.Rich(item.Prefab.Name).SanitizedValue;
+
+        var font = GUIStyle.SubHeadingFont.GetFontForStr(nameText)!;
+        Vector2 itemTextSizeScreen = font.MeasureString(nameText) * LabelScale;
         Vector2 interactablePosScreen = cam.WorldToScreen(item.Position);
         RectangleF textRect = new RectangleF(interactablePosScreen.X, interactablePosScreen.Y, itemTextSizeScreen.X, itemTextSizeScreen.Y);
         // center the rectangle on the item

Barotrauma/BarotraumaClient/ClientSource/Characters/Limb.cs

@@ -340,10 +340,6 @@ partial void InitProjSpecific(ContentXElement element)
                         break;
                     case "randomcolor":
                         randomColor = subElement.GetAttributeColorArray("colors", null)?.GetRandomUnsynced();
-                        if (randomColor.HasValue)
-                        {
-                            Params.GetSprite().Color = randomColor.Value;
-                        }
                         break;
                     case "lightsource":
                         LightSource = new LightSource(subElement, GetConditionalTarget())
@@ -631,6 +627,8 @@ partial void AddDamageProjSpecific(bool playSound, AttackResult result)
                 SoundPlayer.PlayDamageSound(damageSoundType, Math.Max(damage, bleedingDamage), WorldPosition);
             }
 
+            if (character.InvisibleTimer > 0.0f) { return; }
+
             // spawn damage particles
             float damageParticleAmount = damage < 1 ? 0 : Math.Min(damage / 5, 1.0f) * damageMultiplier;
             if (damageParticleAmount > 0.001f)
@@ -734,7 +732,8 @@ public void Draw(SpriteBatch spriteBatch, Camera cam, Color? overrideColor = nul
             if (spriteParams == null || Alpha <= 0) { return; }
             float burn = spriteParams.IgnoreTint ? 0 : burnOverLayStrength;
             float brightness = Math.Max(1.0f - burn, 0.2f);
-            Color tintedColor = spriteParams.Color;
+            Color baseColor = randomColor ?? spriteParams.Color;
+            Color tintedColor = baseColor;
             if (!spriteParams.IgnoreTint)
             {
                 tintedColor = tintedColor.Multiply(ragdoll.RagdollParams.Color);
@@ -752,7 +751,7 @@ public void Draw(SpriteBatch spriteBatch, Camera cam, Color? overrideColor = nul
                 }
             }
             Color color = new Color(tintedColor.Multiply(brightness), tintedColor.A);
-            Color colorWithoutTint = new Color(spriteParams.Color.Multiply(brightness), spriteParams.Color.A);
+            Color colorWithoutTint = new Color(baseColor.Multiply(brightness), baseColor.A);
             Color blankColor = new Color(brightness, brightness, brightness, 1);
             if (deadTimer > 0)
             {

Barotrauma/BarotraumaClient/ClientSource/CircuitBox/CircuitBoxInputOutputNode.cs

@@ -31,7 +31,7 @@ public void PromptEdit(GUIComponent parent)
 
                 GUILayoutGroup connLayout = new GUILayoutGroup(new RectTransform(new Vector2(1f, 0.12f), labelList.Content.RectTransform), isHorizontal: true, childAnchor: Anchor.CenterLeft);
                 new GUITextBlock(new RectTransform(new Vector2(0.4f, 1f), connLayout.RectTransform), text: conn.Connection.DisplayName, font: GUIStyle.SubHeadingFont);
-                GUITextBox box = GUI.CreateTextBoxWithPlaceholder(new RectTransform(new Vector2(0.6f, 1f), connLayout.RectTransform), text: found ? labelOverride : string.Empty, conn.Connection.DisplayName.Value);
+                GUITextBox box = GUI.CreateTextBoxWithPlaceholder(new RectTransform(new Vector2(0.6f, 1f), connLayout.RectTransform), text: found ? labelOverride : string.Empty, conn.Connection.DefaultDisplayName.Value);
                 box.MaxTextLength = MaxConnectionLabelLength;
 
                 textBoxes.Add(conn.Name, box);

Barotrauma/BarotraumaClient/ClientSource/DebugConsole.cs

@@ -16,6 +16,7 @@
 using System.Text;
 using System.Threading.Tasks;
 using System.Xml.Linq;
+using Barotrauma.LuaCs.Events;
 using static Barotrauma.FabricationRecipe;
 
 namespace Barotrauma
@@ -222,8 +223,6 @@ public static void Toggle()
 
         private static bool IsCommandPermitted(Identifier command, GameClient client)
         {
-            if (GameMain.LuaCs.Game.IsCustomCommandPermitted(command)) { return true; }
-
             switch (command.Value.ToLowerInvariant())
             {
                 case "kick":
@@ -659,14 +658,6 @@ async Task gameOwnershipTokenTest()
                     return;
                 }
 
-                bool luaCsEnabled = true;
-                if (args.Length > 3)
-                {
-                    bool.TryParse(args[3], out luaCsEnabled);
-                }
-
-                if (luaCsEnabled) { GameMain.LuaCs.Initialize(); }
-
                 GameMain.MainMenuScreen.QuickStart(fixedSeed: false, subName, difficulty, levelGenerationParams);
 
             }, getValidArgs: () => new[] { SubmarineInfo.SavedSubmarines.Select(s => s.Name).Distinct().OrderBy(s => s).ToArray() }));
@@ -4223,51 +4214,8 @@ void getTextsFromElement(XElement element, List<string> list, string parentName)
                     NewMessage("Minimum main path width: " + (Level.Loaded.LevelData?.MinMainPathWidth?.ToString() ?? "unknown"));
                 }
             });
-
-            commands.Add(new Command("cl_lua", $"cl_lua: Runs a string on the client.", (string[] args) =>
-            {
-                if (GameMain.Client != null && !GameMain.Client.HasPermission(ClientPermissions.ConsoleCommands))
-                {
-                    ThrowError("Command not permitted.");
-                    return;
-                }
-
-                if (GameMain.LuaCs.Lua == null)
-                {
-                    ThrowError("LuaCs not initialized, use the console command cl_reloadluacs to force initialization.");
-                    return;
-                }
-
-                try
-                {
-                    GameMain.LuaCs.Lua.DoString(string.Join(" ", args));
-                }
-                catch(Exception ex)
-                {
-                    LuaCsLogger.HandleException(ex, LuaCsMessageOrigin.LuaMod);
-                }
-            }));
-
-            commands.Add(new Command("cl_reloadlua|cl_reloadcs|cl_reloadluacs", "Re-initializes the LuaCs environment.", (string[] args) =>
-            {
-                GameMain.LuaCs.Initialize();
-            }));
-
-            commands.Add(new Command("cl_toggleluadebug", "Toggles the MoonSharp Debug Server.", (string[] args) =>
-            {
-                int port = 41912;
-
-                if (args.Length > 0)
-                {
-                    int.TryParse(args[0], out port);
-                }
-
-                GameMain.LuaCs.ToggleDebugger(port);
-            }));
         }
 
-
-
         private static void ReloadWearables(Character character, int variant = 0)
         {
             foreach (var limb in character.AnimController.Limbs)

Barotrauma/BarotraumaClient/ClientSource/Events/EventActions/ConversationAction.cs

@@ -277,6 +277,14 @@ void AssignActionsToButtons(List<GUIButton> optionButtons, GUIMessageBox target)
                         int selectedOption = (userdata as int?) ?? 0;
                         if (actionInstance != null)
                         {
+                            var option = actionInstance.Options[selectedOption];
+                            if (GameMain.Client == null && option.ForceSay)
+                            {
+                                Character.Controlled.ForceSay(
+                                    option.ForceSayText.IsNullOrEmpty() ? TextManager.Get(option.Text).Fallback(option.Text) : TextManager.Get(option.ForceSayText).Fallback(option.ForceSayText),
+                                    option.ForceSayInRadio,
+                                    option.ForceSayRemoveQuotes);
+                            }
                             actionInstance.selectedOption = selectedOption;
                             DisableButtons(optionButtons, btn);
                             btn.ExternalHighlight = true;
@@ -340,7 +348,8 @@ private static List<GUIButton> CreateConversation(GUIListBox parentBox, Localize
             if (speaker?.Info != null && drawChathead)
             {
                 // chathead
-                new GUICustomComponent(new RectTransform(new Vector2(0.15f, 0.8f), content.RectTransform), onDraw: (sb, customComponent) =>
+                int chatHeadWidth = (int)(content.RectTransform.Rect.Width * 0.15f);
+                new GUICustomComponent(new RectTransform(new Point(chatHeadWidth, chatHeadWidth), content.RectTransform, isFixedSize: true), onDraw: (sb, customComponent) =>
                 {
                     speaker.Info.DrawIcon(sb, customComponent.Rect.Center.ToVector2(), customComponent.Rect.Size.ToVector2());
                 });
@@ -382,7 +391,7 @@ private static List<GUIButton> CreateConversation(GUIListBox parentBox, Localize
             }
 
             textContent.RectTransform.MinSize = new Point(0, textContent.Children.Sum(c => c.Rect.Height + textContent.AbsoluteSpacing) + GUI.IntScale(16));
-            content.RectTransform.MinSize = new Point(0, content.Children.Sum(c => c.Rect.Height));
+            content.RectTransform.MinSize = textContent.RectTransform.MinSize;
 
             // Recalculate the text size as it is scaled up and no longer matching the text height due to the textContent's minSize increasing
             textBlock.CalculateHeightFromText();

Barotrauma/BarotraumaClient/ClientSource/Events/Missions/AbandonedOutpostMission.cs

@@ -61,17 +61,9 @@ public override void ClientReadInitial(IReadMessage msg)
                 {
                     Item.ReadSpawnData(msg);
                 }
-                if (character.Submarine != null && character.AIController is EnemyAIController enemyAi)
+                if (character.AIController is EnemyAIController enemyAi && character.Submarine is Submarine ownSub)
                 {
-                    enemyAi.UnattackableSubmarines.Add(character.Submarine);
-                    if (Submarine.MainSub != null)
-                    {
-                        enemyAi.UnattackableSubmarines.Add(Submarine.MainSub);
-                        foreach (Submarine sub in Submarine.MainSub.DockedTo)
-                        {
-                            enemyAi.UnattackableSubmarines.Add(sub);
-                        }
-                    }
+                    enemyAi.SetUnattackableSubmarines(ownSub);
                 }
             }
             if (characters.Contains(null))

Barotrauma/BarotraumaClient/ClientSource/Events/Missions/CustomMission.cs

@@ -0,0 +1,8 @@
+#nullable enable
+namespace Barotrauma;
+
+internal sealed partial class CustomMission : Mission
+{
+    public override bool DisplayAsCompleted => State == SuccessState;
+    public override bool DisplayAsFailed => State == FailureState;
+}