Conversation
jr1221
requested changes
Feb 14, 2025
Contributor
jr1221
left a comment
jr1221
left a comment
There was a problem hiding this comment.
tis but a few things. lets see if it works lol
Core/Src/msb.c
Outdated
| #endif | ||
|
|
||
| #ifdef SENSOR_TOF | ||
| #ifdef SENSOR_TOFsht30_t |
Core/Src/msb.c
Outdated
| HAL_StatusTypeDef hal_stat = sht30_get_temp_humid(&temp_sensor); | ||
| if (hal_stat) | ||
| return hal_stat; | ||
| int status = sht30_get_temp_humid(&temp_sensor); |
caiodasilva2005
requested changes
Feb 14, 2025
Core/Src/msb.c
Outdated
| assert(!sht30_init(&temp_sensor)); /* This is always connected */ | ||
| sht30_t temp_sensor; | ||
| assert(!sht30_init(&temp_sensor, (Read_ptr)sht30_i2c_read, | ||
| (Write_ptr)sht30_i2c_write, |
Contributor
There was a problem hiding this comment.
if you change the return type of the function pointer to a unit8_t, then you shouldn't have to cast when passing into init
Core/Src/msb.c
Outdated
| #endif | ||
|
|
||
| #ifdef SENSOR_TOF | ||
| #ifdef SENSOR_TOFsht30_t |
jr1221
previously approved these changes
Apr 9, 2025
| /// @param out | ||
| /// @return error code | ||
| int8_t central_temp_measure(uint16_t *temp, uint16_t *humidity) | ||
| int8_t central_temp_measure(float *temp, float *humidity) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Changed sht30 implementation
To Do
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please reach out to your Project Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.