Skip to content

Enable building without git history#66

Merged
matislovas merged 3 commits intomainfrom
matislovas/fix_build_git_wo_tag
Mar 23, 2026
Merged

Enable building without git history#66
matislovas merged 3 commits intomainfrom
matislovas/fix_build_git_wo_tag

Conversation

@matislovas
Copy link
Contributor

@matislovas matislovas commented Mar 18, 2026

Some build systems strips of git history. Our build.rs script depends on git. So we need a fallback in case of no git history.

@matislovas matislovas force-pushed the matislovas/fix_build_git_wo_tag branch 2 times, most recently from 515ca9f to 4a71566 Compare March 18, 2026 07:03
@matislovas matislovas marked this pull request as ready for review March 18, 2026 07:04
@matislovas matislovas force-pushed the matislovas/fix_build_git_wo_tag branch 3 times, most recently from 854b96d to e815a7c Compare March 18, 2026 07:41
@codecov
Copy link

codecov bot commented Mar 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.14%. Comparing base (faa23c9) to head (e387ef7).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
- Coverage   46.01%   44.14%   -1.87%     
==========================================
  Files          15       15              
  Lines        4375     3869     -506     
==========================================
- Hits         2013     1708     -305     
+ Misses       2362     2161     -201     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@matislovas matislovas force-pushed the matislovas/fix_build_git_wo_tag branch from e815a7c to 38f41f0 Compare March 18, 2026 07:47
Copy link
Contributor

@tomasz-grz tomasz-grz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Signed-off-by: Matas Misiunas <matislovas@gmail.com>
Signed-off-by: Matas Misiunas <matislovas@gmail.com>
@matislovas matislovas force-pushed the matislovas/fix_build_git_wo_tag branch from 38f41f0 to e387ef7 Compare March 18, 2026 12:28
Copy link
Contributor

@Jauler Jauler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1.0

@matislovas matislovas merged commit 0539b28 into main Mar 23, 2026
30 of 31 checks passed
@matislovas matislovas deleted the matislovas/fix_build_git_wo_tag branch March 23, 2026 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants