Support better gas estimation to avoid internal OOG errors - #292
Open
ChristopherDedominici wants to merge 1 commit into
Open
Support better gas estimation to avoid internal OOG errors#292ChristopherDedominici wants to merge 1 commit into
ChristopherDedominici wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds documentation for EDR’s configurable eth_estimateGas behavior, specifically to avoid misleading estimates when internal calls run out of gas.
Changes:
- Documented EDR gas estimation search criteria and the two
gasEstimationModebehaviors (noInternalOutOfGasvstopLevelSuccess). - Added
gasEstimationModeto the simulated network configuration reference and linked to the detailed explanation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/content/docs/docs/reference/edr-simulated-networks.mdx | Adds a new “Gas estimation modes” section explaining how EDR interprets success during eth_estimateGas. |
| src/content/docs/docs/reference/configuration.mdx | Documents the new gasEstimationMode simulated network config option and links to the detailed section. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs for HH PR: NomicFoundation/hardhat#8501