fix(tools): repair no-op --check in op-chain-config generator and update generated configs - #1641
Merged
popescuoctavian merged 5 commits intoAug 25, 2026
Conversation
…pdate generated configs
popescuoctavian
temporarily deployed
to
github-action-benchmark
August 21, 2026 12:14 — with
GitHub Actions
Inactive
🦋 Changeset detectedLatest commit: 5785b20 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
popescuoctavian
temporarily deployed
to
github-action-benchmark
August 21, 2026 12:16 — with
GitHub Actions
Inactive
popescuoctavian
temporarily deployed
to
github-action-benchmark
August 21, 2026 12:16 — with
GitHub Actions
Inactive
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1641 +/- ##
==========================================
- Coverage 80.02% 79.89% -0.13%
==========================================
Files 464 460 -4
Lines 80392 80024 -368
Branches 80392 80024 -368
==========================================
- Hits 64330 63937 -393
- Misses 13856 13882 +26
+ Partials 2206 2205 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Base no longer follows the OP stack protocol, so EDR's OP chain configs cannot represent it correctly. If EDR supports Base again, it should model Base's own protocol.
anaPerezGhiglia
temporarily deployed
to
github-action-benchmark
August 24, 2026 18:44 — with
GitHub Actions
Inactive
anaPerezGhiglia
temporarily deployed
to
github-action-benchmark
August 24, 2026 18:46 — with
GitHub Actions
Inactive
anaPerezGhiglia
had a problem deploying
to
github-action-benchmark
August 24, 2026 18:46 — with
GitHub Actions
Error
Generating the files in a previous step was a leftover of the original implementation of the workflow
anaPerezGhiglia
temporarily deployed
to
github-action-benchmark
August 24, 2026 19:01 — with
GitHub Actions
Inactive
anaPerezGhiglia
temporarily deployed
to
github-action-benchmark
August 24, 2026 19:03 — with
GitHub Actions
Inactive
anaPerezGhiglia
temporarily deployed
to
github-action-benchmark
August 24, 2026 19:03 — with
GitHub Actions
Inactive
popescuoctavian
marked this pull request as ready for review
August 25, 2026 07:06
anaPerezGhiglia
approved these changes
Aug 25, 2026
anaPerezGhiglia
left a comment
Contributor
There was a problem hiding this comment.
LGTM! thanks for pushing for fixing this! 🙇
popescuoctavian
deleted the
popescuoctavian/op-config-generator-git-diff-issue
branch
August 25, 2026 13:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The --check of op-chain-config generator which runs in CI was always succeeding. I've discovered this while testing #1639.
Problem
The cargo op-chain-config -- --check step in the "Check generated files" workflow has never detected out-of-date configs. It used git diff -G'' --exit-code, which was broken three ways:
Changes
Generator (crates/tool/op_chain_config_generator):
Workflow (.github/workflows/check-generated-files.yml):
Regenerated configs (first regeneration since December):
Dropped built-in Base support (crates/edr_op):