Repository navigation
A game menu's credits pane counts as credits - #2377
Merged
Merged
Conversation
Noisemaker111
enabled auto-merge
October 24, 2026 16:19
Noisemaker111
force-pushed
the
agent/lane-credits-pane
branch
from
October 24, 2026 16:28
998e07c to
3420421
Compare
Noisemaker111
force-pushed
the
agent/lane-credits-pane
branch
from
October 24, 2026 16:42
3420421 to
4157f4d
Compare
This was referenced Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two findings from the 0.38.4 pin, one PR because each blocked the other.
Credits pane: the pin failed
check-game-front-endwithGames/deepward - no creditsfor a game that had just moved its credits into the engine's ownGameMenu(CreditsPanein a detail slot). The pattern now countsCreditsPane; Harbor Heat's baselined#creditsentry no longer applies at the current pin and is removed, Brightway Park's stays until the pin that ships its menu.Green smoke: the
ciaggregate asserted that aGAMES=nonechange also skipped smoke, but a script underscripts/**is in the heavy set and not in the game map, soGAMES=nonewithSMOKE=successis a real combination and the assertion failed an otherwise green run.Root cause, both: a gate that lists cases by hand was not updated when the thing it describes changed.
Prevention:
scripts/gameFrontEnd.test.tsscans aGameMenucredits pane and expects onlyprobe#settingsto remain; the aggregate now fails only on a smoke that failed.Verification:
bun test scripts/gameFrontEnd.test.ts8 pass |bun run check-game-front-endok against the pinned Games (7 baselined, none added) | every other job green on this branch, includingtypes|ship:preflightok