This repository was archived by the owner on Oct 25, 2026. It is now read-only.
Repository navigation
Module-globals check reads the engine's rule; declare turf-war - #257
Closed
Noisemaker111 wants to merge 1 commit into
Closed
Noisemaker111 wants to merge 1 commit into
Noisemaker111 wants to merge 1 commit into
Conversation
check:module-globals imports moduleGlobalName and isGameSourceFile from jgengine/gameShape instead of copying the regex. The engine bump this needs brings the turf-war capability: not-applicable in 16 games, debt in Harbor Heat (#256), whose hand-built Carmine turf is that system. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
check:module-globalsimportsmoduleGlobalName/isGameSourceFilefromjgengine/gameShape(Drive step files refuse ignored ms/timeoutMs; export the module-global rule jgengine#2474) instead of a copied regex.engine-ref.txtmoves to engine beta 896e9b99, which carries that export and the newturf-warcapability.turf-wardeclared: not-applicable in 16 games; debt in Harbor Heat (Harbor Heat: run the Carmine turf on the engine's defineTurfWar #256), whosecity.tshand-builds the Carmine turf.Blocked
check:capabilitiesfails the debt budget: Harbor Heat goes from 1 to 2 debt entries, and the budget only goes down. This lands once Harbor Heat adoptsdefineTurfWar(#256) - then flip its entry to adopts and rebase.Engine seam
Engine seam: packages/jgengine/src/gameShape.ts (adopts Noisemaker111/jgengine#2474)
Checks
bun test scripts/module-globals-check.test.tspass;bun run check:module-globalsOK (13 baselined, none added).🤖 Generated with Claude Code