This repository was archived by the owner on Oct 25, 2026. It is now read-only.
Repository navigation
Checks read the engine's own drive rules instead of a copied schema - #255
Merged
Merged
Conversation
Noisemaker111
enabled auto-merge
October 25, 2026 16:46
Noisemaker111
force-pushed
the
agent/checks-read-engine
branch
from
October 25, 2026 17:00
7ad3cdf to
be496a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Checks stop keeping copies of engine rules.
scripts/flow-schema.ts(which once required rpc steps to be strings while drive takes objects) is gone.check:game-designparses each Loop proof with drive's ownparseStepFilefromjgengine/templates/captureArgs, includes and all, so it refuses a flow exactly whendrivewould.jgengineCLI package joins the catalog and is built and linked fromengine-ref.txtlike every@jgengine/*(engine-mode.ts,engine-pin.ts).provevalidates--tierwith the engine'sparseGraphicsTier;capabilities:probereads everywindow.__jgengine*readout instead of a two-name list.{"key": "KeyW:2000"}, which drive refuses. A test fixture used it.Engine seam
Engine seam: packages/jgengine/src/templates/captureArgs.ts (adopts Noisemaker111/jgengine#2474)
Checks
scripts/check-game-design.test.ts: every engine step kind is accepted; a corpus of good and bad steps gets the engine's exact verdict; a swapped-in newer or stricter engine parser changes the gate's verdict with no gate edit.bun run verify:fastpassed (26 steps);bun run check:game-designOK on all 11 games.🤖 Generated with Claude Code