Repository navigation
[AUTOMATED] Pin the fatstr-records witness to a runtime-indexed table (rustc 1.99 emits no record for println pieces) - #1275
Merged
Conversation
… (rustc 1.99 emits no record for println pieces) CI runs rustc 1.99.1, whose format lowering no longer materializes a (ptr,len) record for a println literal piece - no relocation and no pointer word reference the piece anywhere in the image (measured against 1.90.0, where the pieces record carries the relocated slot the e2e was pinned to). A bare static &str is likewise const-folded into code at -O. The witness is now a runtime-indexed [&str; 3] table, which cannot fold and emits three records in .data.rel.ro under both toolchains (verified: RELATIVE slot with the 21-byte length companion on 1.90.0 and 1.99.1); it is also the shape the record pass most often feeds on in real binaries. Test-only change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WoTv7T2Ep5hmbZcyYSMk1g
mahaloz
added
the
full-ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main's workspace suite is red on
verify_fatstr_records: CI runs rustc 1.99.1, whose format lowering no longer materializes a(ptr, len)record for aprintln!literal piece — no relocation and no pointer word reference the piece anywhere in the image (measured against 1.90.0, where the pieces record carries the relocated slot the e2e was pinned to). A barestatic &stris likewise const-folded at-O.The witness is now a runtime-indexed
[&str; 3]table, which cannot fold and emits three records in.data.rel.rounder both toolchains (verified: RELATIVE slot plus the 21-byte length companion on 1.90.0 and 1.99.1). That is also the most common real-world shape the record pass feeds on. Test-only change; the test passes under both rustc versions locally.🤖 Generated with Claude Code
https://claude.ai/code/session_01WoTv7T2Ep5hmbZcyYSMk1g