Skip to content

feat: refactor spinner implementation and add tests for raw output mode #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Scafu merged 7 commits into from
Apr 3, 2026

fix: add mustMarkRequired function and tests for flag requirements

5504fd0
Select commit
Loading
Failed to load commit list.
Merged

feat: refactor spinner implementation and add tests for raw output mode #2

fix: add mustMarkRequired function and tests for flag requirements
5504fd0
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Apr 3, 2026 in 15s

Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
80.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check failure on line 462 in internal/client/client_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "expected decode error, got nil" 6 times. 

See more on https://sonarcloud.io/project/issues?id=NoTIPswe_notip-simulator-frontend&issues=AZ1U-QB9ojYqUzZi77QL&open=AZ1U-QB9ojYqUzZi77QL&pullRequest=2

Check failure on line 53 in internal/client/client_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "uuid-1" 9 times. 

See more on https://sonarcloud.io/project/issues?id=NoTIPswe_notip-simulator-frontend&issues=AZ1UPxK-oSY2jLlbuOk_&open=AZ1UPxK-oSY2jLlbuOk_&pullRequest=2

Check failure on line 470 in internal/client/client_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "not-json" 5 times. 

See more on https://sonarcloud.io/project/issues?id=NoTIPswe_notip-simulator-frontend&issues=AZ1U-QB9ojYqUzZi77QK&open=AZ1U-QB9ojYqUzZi77QK&pullRequest=2

Check failure on line 185 in internal/client/client_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "not found" 6 times. 

See more on https://sonarcloud.io/project/issues?id=NoTIPswe_notip-simulator-frontend&issues=AZ1UPxK-oSY2jLlbuOk-&open=AZ1UPxK-oSY2jLlbuOk-&pullRequest=2

Check failure on line 72 in internal/client/client_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "unexpected error: %v" 16 times. 

See more on https://sonarcloud.io/project/issues?id=NoTIPswe_notip-simulator-frontend&issues=AZ1UPxK-oSY2jLlbuOk8&open=AZ1UPxK-oSY2jLlbuOk8&pullRequest=2

Check failure on line 31 in internal/client/client_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Content-Type" 7 times. 

See more on https://sonarcloud.io/project/issues?id=NoTIPswe_notip-simulator-frontend&issues=AZ1UPxK-oSY2jLlbuOlB&open=AZ1UPxK-oSY2jLlbuOlB&pullRequest=2

Check failure on line 189 in internal/client/client_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "expected error on 404, got nil" 6 times. 

See more on https://sonarcloud.io/project/issues?id=NoTIPswe_notip-simulator-frontend&issues=AZ1UPxK-oSY2jLlbuOlA&open=AZ1UPxK-oSY2jLlbuOlA&pullRequest=2

Check failure on line 31 in internal/client/client_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "application/json" 7 times. 

See more on https://sonarcloud.io/project/issues?id=NoTIPswe_notip-simulator-frontend&issues=AZ1UPxK-oSY2jLlbuOk9&open=AZ1UPxK-oSY2jLlbuOk9&pullRequest=2
View more details on SonarQubeCloud