Skip to content

hunk: 0.21.1 -> 0.22.0 - #567355

Merged
drupol merged 1 commit into
NixOS:masterfrom
kaynetik:hunk_0.22.0_fix
Sep 27, 2026
Merged

hunk: 0.21.1 -> 0.22.0#567355
drupol merged 1 commit into
NixOS:masterfrom
kaynetik:hunk_0.22.0_fix

Conversation

@kaynetik

@kaynetik kaynetik commented Sep 27, 2026

Copy link
Copy Markdown
Member

Update hunk from 0.21.1 to 0.22.0.

The automated bump failed in postPatch (nixpkgs-update log):

substitute(): ERROR: file 'src/core/run/paths.ts' does not exist

Upstream v0.22.0 turned the repository into a Bun workspace (modem-dev/hunk#997). The app, its entry points and its shipped skills now live under packages/hunk. The root skills/ directory only holds maintainer skills, which are not shipped.

Changes:

  • Compile packages/hunk/src/main.tsx and packages/hunk/src/highlightWorkerEntry.ts, the same entry points as upstream's scripts/build/build-bin.ts.
  • Install skills from packages/hunk/skills/* with installSkill.
  • Drop the substituteInPlace patch on paths.ts. hunk skill path searches the directories above the executable for skills/<name>/SKILL.md, so a $out/skills -> share/skills/hunk symlink is enough and the sources stay unpatched. Upstream's own nix/package.nix uses the same $out/skills layout.
  • Remove the duplicate --version check, which versionCheckHook already covers.
    With these changes, routine version bumps only need the source and node_modules hash updates that nixpkgs-update already makes.

Things done

@kaynetik
hunk: 0.21.1 -> 0.22.0
bbc7ddf 
Upstream moved the app into `packages/hunk`. Build and install skills
from the new paths, and replace the `paths.ts` patch with a
`$out/skills` symlink that `hunk skill path` already resolves.

Signed-off-by: kaynetik <aleksandar@nesovic.dev>
@kaynetik
kaynetik marked this pull request as ready for review September 27, 2026 07:26
@kaynetik

kaynetik commented Sep 27, 2026

Copy link
Copy Markdown
Member Author

And just one tiny personal note on this package, from what I've followed this was the 6th time there was a breaking change in how the upstream is dealing with skills & packaging.

FMPOV they are vibecoding a bit too much. 😂

@nixpkgs-ci
nixpkgs-ci Bot requested a review from MarkusZoppelt September 27, 2026 07:32
@nixpkgs-ci nixpkgs-ci Bot added 8.has: package (update) This PR updates a package to a newer version 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Sep 27, 2026
@nixpkgs-review-gha

nixpkgs-review-gha commented Sep 27, 2026

Copy link
Copy Markdown

✅ nixpkgs-review result

Generated using nixpkgs-review-gha (05be241)

Command: nixpkgs-review pr 567355
Commit: bbc7ddf06095efae3d9a18cdc10a6c4aafda7875 (subsequent changes)
Merge: 731b3516e8c5feffcc14fd58168b29ec1b76f0c9

Triggered by @kaynetik (48174247)
Logs: https://github.com/kaynetik/nixpkgs-review-gha/actions/runs/36303122512/attempts/1

x86_64-linux

✅ 1 package built:
  • hunk

aarch64-linux

✅ 1 package built:
  • hunk

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • hunk

@kaynetik
kaynetik requested a review from drupol September 27, 2026 07:58
@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Sep 27, 2026
@drupol

drupol commented Sep 27, 2026

Copy link
Copy Markdown
Contributor

✅ nixpkgs-review result

Generated using nixpkgs-review-gha (05be241)

Command: nixpkgs-review pr 567355
Commit: bbc7ddf06095efae3d9a18cdc10a6c4aafda7875 (subsequent changes)
Merge: 731b3516e8c5feffcc14fd58168b29ec1b76f0c9

Logs: https://github.com/drupol/nixpkgs-review-gha/actions/runs/36320670993/attempts/1

x86_64-linux

✅ 1 package built:
  • hunk

aarch64-linux

✅ 1 package built:
  • hunk

x86_64-darwin

✅ No rebuilds

aarch64-darwin (sandbox = relaxed)

✅ 1 package built:
  • hunk

drupol
drupol approved these changes Sep 27, 2026
View reviewed changes

@drupol drupol left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

@drupol
drupol added this pull request to the merge queue Sep 27, 2026
Merged via the queue into NixOS:master with commit 864eb18 Sep 27, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drupol drupol drupol approved these changes
+1 more reviewer
@MarkusZoppelt MarkusZoppelt MarkusZoppelt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kaynetik @nixpkgs-review-gha @drupol @MarkusZoppelt