Skip to content

vimPlugins.fff-nvim: fix illegal instructions by targetting a baseline CPU - #545572

Merged
mrcjkb merged 1 commit into
NixOS:masterfrom
saadndm:fix-fff-nvim
Jul 25, 2026
Merged

mrcjkb merged 1 commit into
NixOS:masterfrom
saadndm:fix-fff-nvim

Conversation

@saadndm

@saadndm saadndm commented Jul 25, 2026

Copy link
Copy Markdown
Member

fff-nvim 0.10 uses zlob 1.6.0, which targets the builder's native CPU by default, making the build impure and causing SIGILL on other CPUs.

This follows dmtrKovalenko/fff#707 and sets CI=1 to target a portable CPU baseline.

Things done

@nixpkgs-ci
nixpkgs-ci Bot requested review from a team and GaetanLepage July 25, 2026 11:19
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 6.topic: vim Advanced text editor labels Jul 25, 2026
@saadndm

saadndm commented Jul 25, 2026

Copy link
Copy Markdown
Member Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 545572
Commit: 8ce69b14f4621fd64f088704ae2a76e219cd7fc0 (subsequent changes)
Merge: e9af6309669b64d4e2883e11b394fa6996f9c6e8

Logs: https://github.com/saadndm/nixpkgs-review-gha/actions/runs/30156215878


x86_64-linux

✅ 1 package built:
  • vimPlugins.fff-nvim

aarch64-linux

✅ 1 package built:
  • vimPlugins.fff-nvim

x86_64-darwin

✅ No rebuilds


aarch64-darwin (sandbox = relaxed)

✅ 1 package built:
  • vimPlugins.fff-nvim

@mrcjkb
mrcjkb added this pull request to the merge queue Jul 25, 2026
@nixpkgs-ci nixpkgs-ci Bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 25, 2026
Merged via the queue into NixOS:master with commit f3ca8c8 Jul 25, 2026
33 checks passed
@saadndm
saadndm deleted the fix-fff-nvim branch July 25, 2026 12:57
@saadndm saadndm mentioned this pull request Aug 10, 2026
5 of 13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: vim Advanced text editor 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants